Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2044643003: Revert of Fix event page process cleanup when running in --isolate-extensions mode. (Closed)

Created:
4 years, 6 months ago by nasko
Modified:
4 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix event page process cleanup when running in --isolate-extensions mode. (patchset #6 id:100001 of https://codereview.chromium.org/2028873002/ ) Reason for revert: Speculative revert of this CL to check if it is the root cause of https://crbug.com/616989. Original issue's description: > Fix event page process cleanup when running in --isolate-extensions mode. > > With --isolate-extensions, navigations can start in one RenderFrameHost > and complete in another. This was not possible to happen with extensions > related RenderFrameHosts in the past, so the code wasn't able to handle > it. This CL refactors the OnNetworkRequest(Started|Stopped) to use the > navigation request id as the stable identifier instead of the associated > RenderFrameHost. > > BUG=612668 > > Committed: https://crrev.com/c25500369dd9a7f49d2b7d276556b2e22ba840c8 > Cr-Commit-Position: refs/heads/master@{#397328} TBR=rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=612668 Committed: https://crrev.com/3cae185174cf799005ee4d4f6147e01fad45e354 Cr-Commit-Position: refs/heads/master@{#398185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -81 lines) Patch
M chrome/browser/extensions/lazy_background_page_apitest.cc View 3 chunks +2 lines, -38 lines 0 comments Download
D chrome/test/data/extensions/api_test/lazy_background_page/event_page_with_web_iframe/event_page.html View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/extensions/api_test/lazy_background_page/event_page_with_web_iframe/manifest.json View 1 chunk +0 lines, -12 lines 0 comments Download
M extensions/browser/process_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/process_manager.cc View 1 chunk +12 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nasko
Created Revert of Fix event page process cleanup when running in --isolate-extensions mode.
4 years, 6 months ago (2016-06-06 23:42:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044643003/1
4 years, 6 months ago (2016-06-06 23:43:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 01:11:50 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3cae185174cf799005ee4d4f6147e01fad45e354 Cr-Commit-Position: refs/heads/master@{#398185}
4 years, 6 months ago (2016-06-07 01:16:10 UTC) #6
nasko
4 years, 6 months ago (2016-06-07 20:10:22 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2040293002/ by nasko@chromium.org.

The reason for reverting is: Reverting the revert, as the speculation of this CL
being the root cause did not pan out -
https://bugs.chromium.org/p/chromium/issues/detail?id=616989#c36..

Powered by Google App Engine
This is Rietveld 408576698