Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 2044583002: Improve NetLog logging in net::BidirectionalStream (Closed)

Created:
4 years, 6 months ago by xunjieli
Modified:
4 years, 6 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve NetLog logging in net::BidirectionalStream This CL adds three additional events to net::BidirectionalStream to log when buffers are coalesced, when stream is ready, and when stream is failed. BUG=617698 Committed: https://crrev.com/2704f5d77380f5a941a3d0f31c9bcbc0ea68fffb Cr-Commit-Position: refs/heads/master@{#399198}

Patch Set 1 #

Patch Set 2 : self review #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -0 lines) Patch
M net/http/bidirectional_stream.cc View 1 2 3 chunks +18 lines, -0 lines 0 comments Download
M net/http/bidirectional_stream_unittest.cc View 1 2 3 chunks +51 lines, -0 lines 0 comments Download
M net/log/net_log_event_type_list.h View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
xunjieli
4 years, 6 months ago (2016-06-06 18:35:56 UTC) #3
mef
lgtm
4 years, 6 months ago (2016-06-09 21:10:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044583002/20001
4 years, 6 months ago (2016-06-09 21:12:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/217041) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-09 21:15:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044583002/40001
4 years, 6 months ago (2016-06-10 14:52:07 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-10 16:02:35 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 16:02:41 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 16:04:33 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2704f5d77380f5a941a3d0f31c9bcbc0ea68fffb
Cr-Commit-Position: refs/heads/master@{#399198}

Powered by Google App Engine
This is Rietveld 408576698