Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: net/log/net_log_event_type_list.h

Issue 2044583002: Improve NetLog logging in net::BidirectionalStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/bidirectional_stream_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/log/net_log_event_type_list.h
diff --git a/net/log/net_log_event_type_list.h b/net/log/net_log_event_type_list.h
index 46e6b65271125602fec2ebea4fbfc3c20b949bdc..d97a391e29d25ee0f4549820cc40447a2cd6e767 100644
--- a/net/log/net_log_event_type_list.h
+++ b/net/log/net_log_event_type_list.h
@@ -1179,6 +1179,13 @@ EVENT_TYPE(HTTP_TRANSACTION_RESTART_AFTER_ERROR)
// }
EVENT_TYPE(BIDIRECTIONAL_STREAM_ALIVE)
+// Marks the beginning/end of buffers sent in a net::BidirectionalStream.
+// The following parameters are attached:
+// {
+// "num_buffers_coalesced": <number of buffers that were sent together>,
+// }
+EVENT_TYPE(BIDIRECTIONAL_STREAM_BYTES_SENT_COALESCED)
+
// The specified number of bytes were sent on the stream. Depending on the
// source of the event, may be logged either once the data is sent, or when it
// is queued to be sent.
@@ -1213,6 +1220,21 @@ EVENT_TYPE(BIDIRECTIONAL_STREAM_RECV_HEADERS)
// }
EVENT_TYPE(BIDIRECTIONAL_STREAM_RECV_TRAILERS)
+// This event is used when stream is successfully negotiated and is ready for
+// sending data and reading data.
+// The following parameters are attached:
+// {
+// "request_headers_sent": <boolean>,
+// }
+EVENT_TYPE(BIDIRECTIONAL_STREAM_READY)
+
+// This event is used when stream has failed.
+// The following parameters are attached:
+// {
+// "net_error": <Net error code for the failure>,
+// }
+EVENT_TYPE(BIDIRECTIONAL_STREAM_FAILED)
+
// ------------------------------------------------------------------------
// SpdySession
// ------------------------------------------------------------------------
« no previous file with comments | « net/http/bidirectional_stream_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698