Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Issue 2044533002: Re-enable IndexedDB tests that weren't really flaky (Closed)

Created:
4 years, 6 months ago by johnme
Modified:
4 years, 6 months ago
Reviewers:
agrieve, jsbell
CC:
chromium-reviews, darin-cc_chromium.org, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable IndexedDB tests that weren't really flaky The following tests were marked flaky in https://crbug.com/616100 and https://crbug.com/616155: - IndexedDBBrowserTest.GetAllMaxMessageSize - IndexedDBBrowserTest.CanDeleteWhenOverQuotaTest - IndexedDBBrowserTest.DeleteCompactsBackingStore But they're not so much flaky, as genuinely broken since https://codereview.chromium.org/2018663002 landed. That patch will soon be fixed or reverted now that it has been identified as the root cause. BUG=616155, 616100 TBR=jsbell@chromium.org Committed: https://crrev.com/cccf913208aa51a4a2a8c2837f949633a53d5baf Cr-Commit-Position: refs/heads/master@{#398271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -19 lines) Patch
M content/browser/indexed_db/indexed_db_browsertest.cc View 3 chunks +4 lines, -19 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
johnme
4 years, 6 months ago (2016-06-06 16:41:06 UTC) #2
agrieve
On 2016/06/06 16:41:06, johnme wrote: lgtm. revert is here: https://codereview.chromium.org/2044523003/ Thanks John!
4 years, 6 months ago (2016-06-06 20:23:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044533002/1
4 years, 6 months ago (2016-06-07 10:41:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/196187)
4 years, 6 months ago (2016-06-07 10:47:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044533002/1
4 years, 6 months ago (2016-06-07 10:53:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 11:38:55 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 11:40:38 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cccf913208aa51a4a2a8c2837f949633a53d5baf
Cr-Commit-Position: refs/heads/master@{#398271}

Powered by Google App Engine
This is Rietveld 408576698