Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: content/browser/indexed_db/indexed_db_browsertest.cc

Issue 2044533002: Re-enable IndexedDB tests that weren't really flaky (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/indexed_db/indexed_db_browsertest.cc
diff --git a/content/browser/indexed_db/indexed_db_browsertest.cc b/content/browser/indexed_db/indexed_db_browsertest.cc
index a70b52ec59a86f5e82a9af2c61909205217d7ec1..922d5bea0fdefc9c60ae41ad358710d221e02f87 100644
--- a/content/browser/indexed_db/indexed_db_browsertest.cc
+++ b/content/browser/indexed_db/indexed_db_browsertest.cc
@@ -246,14 +246,7 @@ IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, CallbackAccounting) {
SimpleTest(GetTestUrl("indexeddb", "callback_accounting.html"));
}
-
-// https://crbug.com/616155
-#if defined(ANDROID)
-#define MAYBE_GetAllMaxMessageSize DISABLED_GetAllMaxMessageSize
-#else
-#define MAYBE_GetAllMaxMessageSize GetAllMaxMessageSize
-#endif
-IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, MAYBE_GetAllMaxMessageSize) {
+IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, GetAllMaxMessageSize) {
SimpleTest(GetTestUrl("indexeddb", "getall_max_message_size.html"));
}
@@ -437,9 +430,7 @@ IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, LevelDBLogFileTest) {
EXPECT_GT(size, 0);
}
-// Disabled due to flakes on Android bots. See crbug.com/616100.
-IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest,
- DISABLED_CanDeleteWhenOverQuotaTest) {
+IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, CanDeleteWhenOverQuotaTest) {
SimpleTest(GetTestUrl("indexeddb", "fill_up_5k.html"));
int64_t size = RequestDiskUsage();
const int kQuotaKilobytes = 2;
@@ -740,14 +731,8 @@ INSTANTIATE_TEST_CASE_P(IndexedDBBrowserTestInstantiation,
"iterate",
"failTransactionCommit",
"clearObjectStore"));
-// https://crbug.com/616155
-#if defined(ANDROID)
-#define MAYBE_DeleteCompactsBackingStore DISABLED_DeleteCompactsBackingStore
-#else
-#define MAYBE_DeleteCompactsBackingStore DeleteCompactsBackingStore
-#endif
-IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest,
- MAYBE_DeleteCompactsBackingStore) {
+
+IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, DeleteCompactsBackingStore) {
const GURL test_url = GetTestUrl("indexeddb", "delete_compact.html");
SimpleTest(GURL(test_url.spec() + "#fill"));
int64_t after_filling = RequestDiskUsage();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698