Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2044523003: Revert of 👔 Reland of Move side-loaded test data /sdcard -> /sdcard/gtestdata (Closed)

Created:
4 years, 6 months ago by agrieve
Modified:
4 years, 6 months ago
Reviewers:
jbudorick, mef, Torne, Nico
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, cbentzel+watch_chromium.org, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, michaelbai, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland of Move side-loaded test data /sdcard -> /sdcard/gtestdata (patchset #3 id:300001 of https://codereview.chromium.org/2018663002/ ) Reason for revert: Breaking quota-related tests in content_browsertests https://crbug.com/617213 Original issue's description: > Reland of Move side-loaded test data /sdcard -> /sdcard/chromium_tests_root > > Reason for reland: > Updated webview tests that broke (WebViewLayoutTest.java) > > And use delete_device_stale=True when pushing. This will prevent tests > mistakenly passing when they depend on stale data files from a previous test. > > TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org > BUG=607169 > > Committed: https://crrev.com/2524a0db714a44fbce723e00f6ed914e6d143cb6 > Cr-Commit-Position: refs/heads/master@{#396479} TBR=jbudorick@chromium.org,thakis@chromium.org,mef@chromium.org,torne@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=607169, 617213, 616155 Committed: https://crrev.com/55ff9438e11da5a78a6ba5d100cebfcfdbc07deb Cr-Commit-Position: refs/heads/master@{#398137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -135 lines) Patch
M android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java View 3 chunks +3 lines, -2 lines 0 comments Download
M android_webview/tools/system_webview_shell/test/data/run_tests.sh View 1 chunk +2 lines, -2 lines 0 comments Download
M base/base_paths_android.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/util/UrlUtils.java View 2 chunks +2 lines, -9 lines 0 comments Download
M base/test/test_support_android.h View 1 chunk +1 line, -3 lines 0 comments Download
M base/test/test_support_android.cc View 4 chunks +8 lines, -15 lines 0 comments Download
M build/android/pylib/local/device/local_device_gtest_run.py View 1 chunk +3 lines, -7 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 3 chunks +6 lines, -12 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_test_run.py View 1 chunk +0 lines, -2 lines 0 comments Download
M build/apk_test.gypi View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M components/cronet/android/test/mock_cert_verifier.cc View 2 chunks +3 lines, -11 lines 0 comments Download
M components/cronet/android/test/native_test_server.cc View 2 chunks +1 line, -8 lines 0 comments Download
M components/cronet/android/test/quic_test_server.cc View 5 chunks +6 lines, -12 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/MockCertVerifier.java View 2 chunks +2 lines, -3 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/NativeTestServer.java View 3 chunks +2 lines, -3 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/QuicTestServer.java View 3 chunks +2 lines, -4 lines 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java View 2 chunks +9 lines, -8 lines 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServerImpl.java View 3 chunks +2 lines, -3 lines 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/util/CertTestUtil.java View 2 chunks +2 lines, -2 lines 0 comments Download
M net/test/embedded_test_server/android/embedded_test_server_android.cc View 2 chunks +1 line, -7 lines 0 comments Download
M testing/android/native_test.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/native_test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTest.java View 3 chunks +2 lines, -3 lines 0 comments Download
M testing/android/native_test/native_test_launcher.cc View 3 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
agrieve
Created Revert of 👔 Reland of Move side-loaded test data /sdcard -> /sdcard/gtestdata
4 years, 6 months ago (2016-06-06 20:14:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044523003/1
4 years, 6 months ago (2016-06-06 20:14:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 22:14:09 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/55ff9438e11da5a78a6ba5d100cebfcfdbc07deb Cr-Commit-Position: refs/heads/master@{#398137}
4 years, 6 months ago (2016-06-06 22:16:07 UTC) #9
agrieve
4 years, 6 months ago (2016-06-07 14:07:49 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2043803003/ by agrieve@chromium.org.

The reason for reverting is: Will update desc when fixed.

Powered by Google App Engine
This is Rietveld 408576698