Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2044353002: [crankshaft] do not sign-extend int32 immediate in DoMathMinMax. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] do not sign-extend int32 immediate in DoMathMinMax. R=bmeurer@chromium.org BUG=chromium:495493 Committed: https://crrev.com/7c3cad2d1472dde8ae11b4169e94e009adf3aec5 Cr-Commit-Position: refs/heads/master@{#36818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-495493.js View 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 6 months ago (2016-06-08 07:09:13 UTC) #1
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-08 09:40:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044353002/1
4 years, 6 months ago (2016-06-08 09:44:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 10:10:07 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 10:12:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c3cad2d1472dde8ae11b4169e94e009adf3aec5
Cr-Commit-Position: refs/heads/master@{#36818}

Powered by Google App Engine
This is Rietveld 408576698