src/crankshaft/x64/lithium-codegen-x64.cc - Issue 2044353002: [crankshaft] do not sign-extend int32 immediate in DoMathMinMax.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/x64/lithium-codegen-x64.cc

Issue 2044353002: [crankshaft] do not sign-extend int32 immediate in DoMathMinMax. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/x64/lithium-codegen-x64.cc

diff --git a/src/crankshaft/x64/lithium-codegen-x64.cc b/src/crankshaft/x64/lithium-codegen-x64.cc

index 67776e4ca9a6b25ad74d5b36d55f4f5c6e0850bb..708691635b4413f0bb61e2e72fd6436ae02c23a0 100644

--- a/src/crankshaft/x64/lithium-codegen-x64.cc

+++ b/src/crankshaft/x64/lithium-codegen-x64.cc

@@ -1779,7 +1779,7 @@ void LCodeGen::DoMathMinMax(LMathMinMax* instr) {

: SmiValuesAre31Bits());

__ cmpl(left_reg, right_imm);

__ j(condition, &return_left, Label::kNear);

- __ movp(left_reg, right_imm);

+ __ movl(left_reg, right_imm);

} else if (right->IsRegister()) {

if (instr->hydrogen_value()->representation().IsSmi()) {

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-495493.js » ('j') | no next file with comments »