Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5366)

Unified Diff: chrome/browser/ui/webui/options/sync_setup_handler.cc

Issue 2044303004: Sync: Support multiple setup UIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix android Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/sync_setup_handler.cc
diff --git a/chrome/browser/ui/webui/options/sync_setup_handler.cc b/chrome/browser/ui/webui/options/sync_setup_handler.cc
index 716aacec8f5559d33164639465dbf948b9d89930..53d491fd783eb3695453fb78ad835e88dce47a11 100644
--- a/chrome/browser/ui/webui/options/sync_setup_handler.cc
+++ b/chrome/browser/ui/webui/options/sync_setup_handler.cc
@@ -301,7 +301,7 @@ void SyncSetupHandler::ConfigureSyncDone() {
// We're done configuring, so notify ProfileSyncService that it is OK to
// start syncing.
- service->SetSetupInProgress(false);
+ setup_handle_.reset();
service->SetFirstSetupComplete();
}
}
@@ -419,7 +419,7 @@ bool SyncSetupHandler::PrepareSyncSetup() {
ProfileSyncService* service = GetSyncService();
if (service)
- service->SetSetupInProgress(true);
+ setup_handle_ = service->GetSetupInProgressHandle();
return true;
}
@@ -726,8 +726,7 @@ void SyncSetupHandler::CloseSyncSetup() {
// Alert the sync service anytime the sync setup dialog is closed. This can
// happen due to the user clicking the OK or Cancel button, or due to the
// dialog being closed by virtue of sync being disabled in the background.
- if (sync_service)
- sync_service->SetSetupInProgress(false);
+ setup_handle_.reset();
configuring_sync_ = false;
}

Powered by Google App Engine
This is Rietveld 408576698