chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc - Issue 2044303004: Sync: Support multiple setup UIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc

Issue 2044303004: Sync: Support multiple setup UIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix android Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/test/integration/profile_sync_service_harness.cc ('K') | « chrome/browser/sync/test/integration/profile_sync_service_harness.cc ('k') | chrome/browser/ui/sync/one_click_signin_sync_starter.h » ('j') | components/browser_sync/browser/profile_sync_service_startup_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc b/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc

index 36642ccd56f82241f6cbff187add5596cedae2eb..3243f6dd3733d191dd73f9756a7bf49ab5fe5a04 100644

--- a/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc

+++ b/chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc

@@ -153,16 +153,16 @@ IN_PROC_BROWSER_TEST_F(TwoClientPasswordsSyncTest,

// When client 1 hits a passphrase required state, we can infer that

// client 0's passphrase has been committed. to the server.

- GetClient(1)->SetupSync();

+ ASSERT_FALSE(GetClient(1)->SetupSync());

ASSERT_TRUE(AwaitPassphraseRequired(GetSyncService(1)));

// Get client 1 out of the passphrase required state.

ASSERT_TRUE(SetDecryptionPassphrase(1, kValidPassphrase));

ASSERT_TRUE(AwaitPassphraseAccepted(GetSyncService(1)));

- // For some reason, the tests won't pass unless these flags are set.

+ // We must mark the first setup complete now, since we just entered the

+ // passphrase and the previous SetupSync() call failed.

GetSyncService(1)->SetFirstSetupComplete();

maxbogue 2016/06/09 20:04:13 Shouldn't this just use ProfileSyncServiceHarness:

tommycli 2016/06/10 00:04:15 Done.

- GetSyncService(1)->SetSetupInProgress(false);

// Move around some passwords to make sure it's all working.

PasswordForm form0 = CreateTestPasswordForm(0);