Issue 204423002: Should remove StyleSheetContents from cache even if document is not active.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204423002: Should remove StyleSheetContents from cache even if document is not active. (Closed)

Created:
6 years, 9 months ago by tasak

Modified:
6 years, 9 months ago

Reviewers:
esprehn, dglazkov

CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Should remove StyleSheetContents from cache even if document is not active. StyleSheetContents cache works independent of document's active(), because StyleElement::process() always invokes StyleEngine::createSheet(). So removeSheetFromCache should also remove 'this' from the cache independent of document's active(). BUG=353894 TEST=fast/dom/move-style-element-to-inactive-document-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169595

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -2 lines)			Patch
A	LayoutTests/fast/dom/move-style-element-to-inactive-document-crash.html	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/dom/move-style-element-to-inactive-document-crash-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/css/CSSStyleSheet.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/css/StyleSheetContents.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/204423002/1

6 years, 9 months ago (2014-03-19 22:57:52 UTC) #4

Message was sent while issue was closed.

Change committed as 169595

Expand Messages | Collapse Messages