Source/core/css/CSSStyleSheet.cpp - Issue 204423002: Should remove StyleSheetContents from cache even if document is not active.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSStyleSheet.cpp

Issue 204423002: Should remove StyleSheetContents from cache even if document is not active. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/move-style-element-to-inactive-document-crash-expected.txt ('k') | Source/core/css/StyleSheetContents.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSStyleSheet.cpp

diff --git a/Source/core/css/CSSStyleSheet.cpp b/Source/core/css/CSSStyleSheet.cpp

index 42fcb47534f9b0d73e4157eb5ea9fe528339091e..1d0336a5c5a0d6342a1173457e7bafa96b4ae1cf 100644

--- a/Source/core/css/CSSStyleSheet.cpp

+++ b/Source/core/css/CSSStyleSheet.cpp

@@ -162,7 +162,8 @@ void CSSStyleSheet::willMutateRules()

// If we are the only client it is safe to mutate.

if (m_contents->clientSize() <= 1 && !m_contents->isInMemoryCache()) {

m_contents->clearRuleSet();

- m_contents->removeSheetFromCache(ownerDocument());

+ if (Document* document = ownerDocument())

+ m_contents->removeSheetFromCache(document);

m_contents->setMutable();

return;

}