Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: chrome/browser/ui/views/status_bubble_views.cc

Issue 2044223006: Make toolbar color opaque in browser theme (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make status bubble background color opaque Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/status_bubble_views.cc
diff --git a/chrome/browser/ui/views/status_bubble_views.cc b/chrome/browser/ui/views/status_bubble_views.cc
index 92c437decbe72b8d7daead0eb65133ce70bd550d..d6f238f2ff0c66c043804516eb1ebf6e44753407 100644
--- a/chrome/browser/ui/views/status_bubble_views.cc
+++ b/chrome/browser/ui/views/status_bubble_views.cc
@@ -371,7 +371,13 @@ void StatusBubbleViews::StatusView::OnPaint(gfx::Canvas* canvas) {
paint.setAntiAlias(true);
SkColor toolbar_color = theme_provider_->GetColor(
ThemeProperties::COLOR_TOOLBAR);
- paint.setColor(toolbar_color);
+ // The status bubble is intentionally set to ignore the alpha value of
+ // toolbar_color, see crbug.com/618278. A partly transparent color with
+ // subpixel rendering of the text may result in weird font in the status
+ // bubble.
Peter Kasting 2016/06/22 05:02:30 Changing things here only fixes the status bubble.
+ paint.setColor(SkColorSetARGB(SK_AlphaOPAQUE, SkColorGetR(toolbar_color),
+ SkColorGetG(toolbar_color),
+ SkColorGetB(toolbar_color)));
gfx::Rect popup_bounds = popup_->GetWindowBoundsInScreen();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698