Make toolbar color opaque in browser theme

chrome/browser/ui/views/status_bubble_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/status_bubble_views.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/i18n/rtl.h"
@@ skipping 353 matching lines @@
 const char* StatusBubbleViews::StatusView::GetClassName() const {
   return "StatusBubbleViews::StatusView";
 }
 
 void StatusBubbleViews::StatusView::OnPaint(gfx::Canvas* canvas) {
   SkPaint paint;
   paint.setStyle(SkPaint::kFill_Style);
   paint.setAntiAlias(true);
   SkColor toolbar_color = theme_provider_->GetColor(
       ThemeProperties::COLOR_TOOLBAR);
-  paint.setColor(toolbar_color);
+  // The status bubble is intentionally set to ignore the alpha value of
+  // toolbar_color, see crbug.com/618278. A partly transparent color with
+  // subpixel rendering of the text may result in weird font in the status
+  // bubble.

[Peter Kasting, 2016/06/22 05:02:30]

Changing things here only fixes the status bubble.  Shouldn't we be changing
this in the theme provider code?

+  paint.setColor(SkColorSetARGB(SK_AlphaOPAQUE, SkColorGetR(toolbar_color),
+                                SkColorGetG(toolbar_color),
+                                SkColorGetB(toolbar_color)));
 
   gfx::Rect popup_bounds = popup_->GetWindowBoundsInScreen();
 
   SkScalar rad[8] = {};
 
   // Top Edges - if the bubble is in its bottom position (sticking downwards),
   // then we square the top edges. Otherwise, we square the edges based on the
   // position of the bubble within the window (the bubble is positioned in the
   // southeast corner in RTL and in the southwest corner in LTR).
   if (style_ != STYLE_BOTTOM) {
@@ skipping 516 matching lines @@
 void StatusBubbleViews::SetBubbleWidth(int width) {
   size_.set_width(width);
   SetBounds(original_position_.x(), original_position_.y(),
             size_.width(), size_.height());
 }
 
 void StatusBubbleViews::CancelExpandTimer() {
   if (expand_timer_factory_.HasWeakPtrs())
     expand_timer_factory_.InvalidateWeakPtrs();
 }