Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 2043973002: [Findit] Fracas crash triage dashboard (Closed)

Created:
4 years, 6 months ago by Sharu Jiang
Modified:
4 years, 5 months ago
Reviewers:
stgao, Martin Barbella
CC:
aarya, mmandlis, findit-review_google.com
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Fracas crash triage dashboard Add dashboard handler and template There are 5 filters for fracas crashes: [start date, end date) filter found suspects. (True, False) has regression range. (True, False) suspected cls triage status (Untriaged, Triaged-Correct, Triaged-Incorrect, Triaged-Unsure) Regression range triage status (Untriaged, Triaged-Correct, Triaged-Incorrect, Triaged-Unsure) The results are sorted by the requested time of the analysis. Move _RemoveMicrosecondsFromDelta, _FormatTimedelta, _FormatDatetime to time_util.py under the common directory. https://findit-for-me.googleplex.com/crash/fracas-dashboard BUG=615267 Committed: https://chromium.googlesource.com/infra/infra/+/0a46c9494b0c8e09edb5aecda004ac78d493f9b3

Patch Set 1 #

Total comments: 12

Patch Set 2 : Address comments. #

Patch Set 3 : #

Total comments: 24

Patch Set 4 : Address comments. #

Patch Set 5 : Fix nits. #

Total comments: 7

Patch Set 6 : Address comments. #

Patch Set 7 : Add comments. #

Patch Set 8 : Rebase. #

Patch Set 9 : Surpass pylint errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+775 lines, -15 lines) Patch
M appengine/findit/common/retry_http_client.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A appengine/findit/common/test/time_util_test.py View 1 chunk +37 lines, -0 lines 0 comments Download
A appengine/findit/common/time_util.py View 1 chunk +27 lines, -0 lines 0 comments Download
M appengine/findit/crash/fracas.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M appengine/findit/crash/fracas_crash_pipeline.py View 1 2 3 4 5 6 7 8 5 chunks +6 lines, -5 lines 0 comments Download
M appengine/findit/crash/test/fracas_test.py View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
A appengine/findit/handlers/crash/fracas_dashboard.py View 1 2 3 4 5 6 7 8 1 chunk +105 lines, -0 lines 0 comments Download
A appengine/findit/handlers/crash/test/fracas_dashboard_test.py View 1 2 3 4 5 1 chunk +274 lines, -0 lines 0 comments Download
M appengine/findit/index.yaml View 1 2 3 1 chunk +108 lines, -0 lines 0 comments Download
M appengine/findit/main.py View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M appengine/findit/model/crash/crash_analysis.py View 1 2 3 4 3 chunks +38 lines, -1 line 0 comments Download
M appengine/findit/model/crash/fracas_crash_analysis.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/findit/model/crash/test/crash_analysis_test.py View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
M appengine/findit/model/crash/test/fracas_crash_analysis_test.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + appengine/findit/model/triage_status.py View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
A appengine/findit/templates/crash/fracas_dashboard.html View 1 2 3 4 5 6 1 chunk +150 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 31 (16 generated)
Sharu Jiang
PTAL :)
4 years, 6 months ago (2016-06-07 01:16:56 UTC) #3
stgao
On 2016/06/07 01:16:56, sharu jiang wrote: > PTAL :) FYI: I'm going to review this ...
4 years, 6 months ago (2016-06-08 17:26:13 UTC) #4
stgao
I will review the html template more closely after I have a UI for reference ...
4 years, 6 months ago (2016-06-08 17:53:45 UTC) #5
Sharu Jiang
updated the url in the description :) https://codereview.chromium.org/2043973002/diff/1/appengine/findit/handlers/crash/fracas_dashboard.py File appengine/findit/handlers/crash/fracas_dashboard.py (right): https://codereview.chromium.org/2043973002/diff/1/appengine/findit/handlers/crash/fracas_dashboard.py#newcode33 appengine/findit/handlers/crash/fracas_dashboard.py:33: """Shows a ...
4 years, 6 months ago (2016-06-09 06:13:28 UTC) #7
stgao
https://codereview.chromium.org/2043973002/diff/60001/appengine/findit/handlers/crash/fracas_dashboard.py File appengine/findit/handlers/crash/fracas_dashboard.py (right): https://codereview.chromium.org/2043973002/diff/60001/appengine/findit/handlers/crash/fracas_dashboard.py#newcode16 appengine/findit/handlers/crash/fracas_dashboard.py:16: from model import analysis_status Not used? https://codereview.chromium.org/2043973002/diff/60001/appengine/findit/index.yaml File appengine/findit/index.yaml ...
4 years, 6 months ago (2016-06-13 21:25:51 UTC) #8
stgao
BTW, the CL description needs some updating.
4 years, 6 months ago (2016-06-13 21:26:19 UTC) #9
Sharu Jiang
https://codereview.chromium.org/2043973002/diff/60001/appengine/findit/handlers/crash/fracas_dashboard.py File appengine/findit/handlers/crash/fracas_dashboard.py (right): https://codereview.chromium.org/2043973002/diff/60001/appengine/findit/handlers/crash/fracas_dashboard.py#newcode16 appengine/findit/handlers/crash/fracas_dashboard.py:16: from model import analysis_status On 2016/06/13 21:25:50, stgao wrote: ...
4 years, 6 months ago (2016-06-21 00:28:14 UTC) #13
Sharu Jiang
PTAL :)
4 years, 6 months ago (2016-06-23 22:22:27 UTC) #16
stgao
lgtm once comments are addressed. https://codereview.chromium.org/2043973002/diff/180001/appengine/findit/templates/crash/fracas_dashboard.html File appengine/findit/templates/crash/fracas_dashboard.html (right): https://codereview.chromium.org/2043973002/diff/180001/appengine/findit/templates/crash/fracas_dashboard.html#newcode39 appengine/findit/templates/crash/fracas_dashboard.html:39: history.pushState({}, null, new_url); If ...
4 years, 6 months ago (2016-06-24 00:49:07 UTC) #17
Sharu Jiang
https://codereview.chromium.org/2043973002/diff/180001/appengine/findit/templates/crash/fracas_dashboard.html File appengine/findit/templates/crash/fracas_dashboard.html (right): https://codereview.chromium.org/2043973002/diff/180001/appengine/findit/templates/crash/fracas_dashboard.html#newcode39 appengine/findit/templates/crash/fracas_dashboard.html:39: history.pushState({}, null, new_url); On 2016/06/24 00:49:07, stgao wrote: > ...
4 years, 5 months ago (2016-06-28 00:11:46 UTC) #18
stgao
Again, the CL description is not up-to-date regarding the status of triaging. https://codereview.chromium.org/2043973002/diff/180001/appengine/findit/templates/crash/fracas_dashboard.html File appengine/findit/templates/crash/fracas_dashboard.html ...
4 years, 5 months ago (2016-06-28 16:40:21 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2043973002/220001
4 years, 5 months ago (2016-06-28 18:55:45 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: Infra Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Presubmit/builds/2753)
4 years, 5 months ago (2016-06-28 19:00:16 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2043973002/260001
4 years, 5 months ago (2016-06-29 18:24:39 UTC) #28
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 18:41:00 UTC) #30
Message was sent while issue was closed.
Committed patchset #10 (id:260001) as
https://chromium.googlesource.com/infra/infra/+/0a46c9494b0c8e09edb5aecda004a...

Powered by Google App Engine
This is Rietveld 408576698