[Findit] Fracas crash triage dashboard

appengine/findit/crash/fracas_crash_pipeline.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 import datetime
 import json
 import logging
 
 from google.appengine.ext import ndb
@@ skipping 43 matching lines @@
     # Update analysis status.
     analysis.pipeline_status_path = self.pipeline_status_path()
     analysis.status = analysis_status.RUNNING
     analysis.started_time = datetime.datetime.utcnow()
     analysis.findit_version = appengine_util.GetCurrentVersion()
     analysis.put()
 
     # Run the analysis.
     result, tags = fracas.FindCulpritForChromeCrash(
         analysis.signature, analysis.platform, analysis.stack_trace,
-        analysis.crashed_version, analysis.historic_metadata)
+        analysis.crashed_version, analysis.historical_metadata)
 
     # Update analysis status and save the analysis result.
     analysis.completed_time = datetime.datetime.utcnow()
     analysis.result = result
     for tag_name, tag_value in tags.iteritems():
       # TODO(http://crbug.com/602702): make it possible to add arbitrary tags.
       if hasattr(analysis, tag_name):
         setattr(analysis, tag_name, tag_value)
     analysis.status = analysis_status.COMPLETED
     analysis.put()
@@ skipping 25 matching lines @@
   # Arguments number differs from overridden method - pylint: disable=W0221
   def run(self, crash_identifiers):
     run_analysis = yield FracasAnalysisPipeline(crash_identifiers)
     with pipeline.After(run_analysis):
       yield PublishResultPipeline(crash_identifiers)
 
 
 @ndb.transactional
 def _NeedsNewAnalysis(
     crash_identifiers, chrome_version, signature, client_id,
-    platform, stack_trace, channel, historic_metadata):
+    platform, stack_trace, channel, historical_metadata):
   analysis = FracasCrashAnalysis.Get(crash_identifiers)
   if analysis and not analysis.failed:
     # A new analysis is not needed if last one didn't complete or succeeded.
     # TODO(http://crbug.com/600535): re-analyze if stack trace or regression
     # range changed.
     logging.info('The analysis of %s has already been done.',
                  repr(crash_identifiers))
     return False
 
   if not analysis:
     # A new analysis is needed if there is no analysis yet.
     analysis = FracasCrashAnalysis.Create(crash_identifiers)
 
   analysis.Reset()
 
   # Set common properties.
   analysis.crashed_version = chrome_version
   analysis.stack_trace = stack_trace
   analysis.signature = signature
   analysis.platform = platform
   analysis.client_id = client_id
 
   # Set customized properties.
-  analysis.historic_metadata = historic_metadata
+  analysis.historical_metadata = historical_metadata
   analysis.channel = channel
 
   # Set analysis progress properties.
   analysis.status = analysis_status.PENDING
   analysis.requested_time = datetime.datetime.utcnow()
 
   analysis.put()
 
   return True
 
 
 def ScheduleNewAnalysisForCrash(
     crash_identifiers, chrome_version, signature, client_id,
-    platform, stack_trace, channel, historic_metadata,
+    platform, stack_trace, channel, historical_metadata,
     queue_name=constants.DEFAULT_QUEUE):
   """Schedules an analysis."""
   crash_config = CrashConfig.Get()
   if platform not in crash_config.fracas.get(
       'supported_platform_list_by_channel', {}).get(channel, []):
     # Bail out if either the channel or platform is not supported yet.
     logging.info('Ananlysis of channel %s, platform %s is not supported. '
                  'No analysis is scheduled for %s',
                  channel, platform, repr(crash_identifiers))
     return False
 
   for blacklist_marker in _SIGNATURE_BLACKLIST_MARKERS:
     if blacklist_marker in signature:
       logging.info('%s signature is not supported. '
                    'No analysis is scheduled for %s', blacklist_marker,
                    repr(crash_identifiers))
       return False
 
   if platform in _PLATFORM_RENAME:
     platform = _PLATFORM_RENAME[platform]
 
   if _NeedsNewAnalysis(crash_identifiers, chrome_version, signature, client_id,
-                       platform, stack_trace, channel, historic_metadata):
+                       platform, stack_trace, channel, historical_metadata):
     analysis_pipeline = FracasCrashWrapperPipeline(crash_identifiers)
+    # Attribute defined outside __init__ - pylint: disable=W0201
     analysis_pipeline.target = appengine_util.GetTargetNameForModule(
         constants.CRASH_BACKEND_FRACAS)
     analysis_pipeline.start(queue_name=queue_name)
     logging.info('New analysis is scheduled for %s', repr(crash_identifiers))
     return True
 
   return False