third_party/WebKit/Source/web/WebPagePopupImpl.cpp - Issue 2043903002: Move didChangeCursor calls from WebViewClient to WebWidgetClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2043903002: Move didChangeCursor calls from WebViewClient to WebWidgetClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/InspectorOverlay.cpp ('K') | « third_party/WebKit/Source/web/InspectorOverlay.cpp ('k') | third_party/WebKit/public/web/WebViewClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

index 5b8f7664fb1613474bf0adcb9300691060be835d..94757f03c0fe13d1b72c36630e6fc51e47b1327c 100644

--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

@@ -160,10 +160,9 @@ private:

return IntSize(0, 0);

}

- void setCursor(const Cursor& cursor, LocalFrame* localRoot) override

+ void setCursor(const Cursor& cursor, LocalFrame* localFrame) override

{

- if (m_popup->m_webView->client())

- m_popup->m_webView->client()->didChangeCursor(WebCursorInfo(cursor));

+ m_popup->m_widgetClient->didChangeCursor(WebCursorInfo(cursor));

}

void setEventListenerProperties(WebEventListenerClass eventClass, WebEventListenerProperties properties) override