Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2043903002: Move didChangeCursor calls from WebViewClient to WebWidgetClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/InspectorOverlay.cpp
diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp
index 795309b67d7bca53c075e5d11263dec0e9659ddf..48ebbfb2f9f07b706a354913ac4263c51d5a0fba 100644
--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp
+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp
@@ -142,7 +142,10 @@ public:
void setCursor(const Cursor& cursor, LocalFrame* localRoot) override
{
toChromeClientImpl(m_client)->setCursorOverridden(false);
- toChromeClientImpl(m_client)->setCursor(cursor, localRoot);
+ // TODO(lfg): Inspector overlay should be fixed to work with
+ // out-of-process iframes. For now, just assume there's a single
+ // widget.
dcheng 2016/07/08 10:38:04 Nit: I'm not sure this needs a TODO, I think it's
lfg 2016/07/11 18:37:24 Done.
+ toChromeClientImpl(m_client)->setCursor(cursor, m_overlay->m_webViewImpl->mainFrameImpl()->frame());
bool overrideCursor = m_overlay->m_layoutEditor;
toChromeClientImpl(m_client)->setCursorOverridden(overrideCursor);
}
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.cpp ('k') | third_party/WebKit/Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698