Declarative resource hints go through mojo IPC to //content

third_party/WebKit/Source/platform/network/NetworkHints.h

Index: third_party/WebKit/Source/platform/network/NetworkHints.h
diff --git a/third_party/WebKit/Source/platform/network/NetworkHints.h b/third_party/WebKit/Source/platform/network/NetworkHints.h
deleted file mode 100644
index 918e560235437db5defabefee7dcc26c683f2c8e..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/platform/network/NetworkHints.h
+++ /dev/null
@@ -1,42 +0,0 @@
-/*
- * Copyright (C) 2008 Collin Jackson  <collinj@webkit.org>
- * Copyright (C) 2013 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef NetworkHints_h
-#define NetworkHints_h
-
-#include "platform/CrossOriginAttributeValue.h"
-#include "platform/PlatformExport.h"
-#include "platform/weborigin/KURL.h"
-#include "wtf/Forward.h"
-
-namespace blink {
-
-PLATFORM_EXPORT void prefetchDNS(const String& hostname);
-PLATFORM_EXPORT void preconnect(const KURL&, const CrossOriginAttributeValue);

[kinuko, 2016/06/16 05:39:58]

I feel we can keep these as is, which could just call into
Platform::current()->mojoServices()->resourceHintsController()->preconnect()
etc?

We don't need to make Platform class just get bloated then.

[Charlie Harrison, 2016/06/16 11:00:19]

What is the point of this class then? I feel like this is a layer of abstraction
that is not really giving us anything, especially if we can just mock
Platform/PlatformMojoServices.

I think the unit tests are much clearer now, and by mocking the mojo services we
can create a mock test harness to mock out all platform IPCs in a general way.

[kinuko, 2016/06/16 13:04:49]

For this one I don't have strong opinion, I seem to have confused you by saying
multiple things...  What I basically wanted to say is that I don't think we
should have all these methods directly exposed on Platform (and guessed you
might have done that to make the callsite's code simpler-- and if that's the
case we could just keep this thin glue layer around).  I'm cool with removing
this part too

[Charlie Harrison, 2016/06/16 14:41:20]

OK that sounds good to me. I agree shoving this in Platform is not great. Will
upload an updated patch set soon.

-
-} // namespace blink
-
-#endif