third_party/WebKit/Source/platform/network/NetworkHints.h - Issue 2043753002: Declarative resource hints go through mojo IPC to //content

Side by Side Diff: third_party/WebKit/Source/platform/network/NetworkHints.h

Issue 2043753002: Declarative resource hints go through mojo IPC to //content Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use unique_ptr to avoid memory leaks in unit tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/platform/exported/Platform.cpp ('K') | « third_party/WebKit/Source/platform/mojo/SecurityOrigin.typemap ('k') | third_party/WebKit/Source/platform/network/NetworkHints.cpp » ('j') | third_party/WebKit/public/platform/Platform.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 /*

2 * Copyright (C) 2008 Collin Jackson <collinj@webkit.org>

3 * Copyright (C) 2013 Google Inc. All rights reserved.

4 *

5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions

7 * are met:

8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright

11 * notice, this list of conditions and the following disclaimer in the

12 * documentation and/or other materials provided with the distribution.

13 *

14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY

15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE

16 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR

17 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR

18 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,

19 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,

20 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR

21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY

22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

25 */

26

27 #ifndef NetworkHints_h

28 #define NetworkHints_h

29

30 #include "platform/CrossOriginAttributeValue.h"

31 #include "platform/PlatformExport.h"

32 #include "platform/weborigin/KURL.h"

33 #include "wtf/Forward.h"

34

35 namespace blink {

36

37 PLATFORM_EXPORT void prefetchDNS(const String& hostname);

38 PLATFORM_EXPORT void preconnect(const KURL&, const CrossOriginAttributeValue);
kinuko 2016/06/16 05:39:58 I feel we can keep these as is, which could just c I feel we can keep these as is, which could just call into Platform::current()->mojoServices()->resourceHintsController()->preconnect() etc? We don't need to make Platform class just get bloated then. Charlie Harrison 2016/06/16 11:00:19 What is the point of this class then? I feel like Show quoted text On 2016/06/16 at 05:39:58, kinuko wrote: > I feel we can keep these as is, which could just call into Platform::current()->mojoServices()->resourceHintsController()->preconnect() etc? > > We don't need to make Platform class just get bloated then. What is the point of this class then? I feel like this is a layer of abstraction that is not really giving us anything, especially if we can just mock Platform/PlatformMojoServices. I think the unit tests are much clearer now, and by mocking the mojo services we can create a mock test harness to mock out all platform IPCs in a general way. kinuko 2016/06/16 13:04:49 For this one I don't have strong opinion, I seem t Show quoted text On 2016/06/16 11:00:19, csharrison wrote: > On 2016/06/16 at 05:39:58, kinuko wrote: > > I feel we can keep these as is, which could just call into > Platform::current()->mojoServices()->resourceHintsController()->preconnect() > etc? > > > > We don't need to make Platform class just get bloated then. > > What is the point of this class then? I feel like this is a layer of abstraction > that is not really giving us anything, especially if we can just mock > Platform/PlatformMojoServices. > > I think the unit tests are much clearer now, and by mocking the mojo services we > can create a mock test harness to mock out all platform IPCs in a general way. For this one I don't have strong opinion, I seem to have confused you by saying multiple things... What I basically wanted to say is that I don't think we should have all these methods directly exposed on Platform (and guessed you might have done that to make the callsite's code simpler-- and if that's the case we could just keep this thin glue layer around). I'm cool with removing this part too Charlie Harrison 2016/06/16 14:41:20 OK that sounds good to me. I agree shoving this in Show quoted text On 2016/06/16 at 13:04:49, kinuko wrote: > On 2016/06/16 11:00:19, csharrison wrote: > > On 2016/06/16 at 05:39:58, kinuko wrote: > > > I feel we can keep these as is, which could just call into > > Platform::current()->mojoServices()->resourceHintsController()->preconnect() > > etc? > > > > > > We don't need to make Platform class just get bloated then. > > > > What is the point of this class then? I feel like this is a layer of abstraction > > that is not really giving us anything, especially if we can just mock > > Platform/PlatformMojoServices. > > > > I think the unit tests are much clearer now, and by mocking the mojo services we > > can create a mock test harness to mock out all platform IPCs in a general way. > > For this one I don't have strong opinion, I seem to have confused you by saying multiple things... What I basically wanted to say is that I don't think we should have all these methods directly exposed on Platform (and guessed you might have done that to make the callsite's code simpler-- and if that's the case we could just keep this thin glue layer around). I'm cool with removing this part too OK that sounds good to me. I agree shoving this in Platform is not great. Will upload an updated patch set soon.
39

40 } // namespace blink

41

42 #endif

OLD	NEW