Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2043553002: PPC: Store Floats as 4 bytes and Double as 8 bytes for codegen (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Store Floats as 4 bytes and Double as 8 bytes for codegen R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/d048ed80c64a7775287d04836da554d7d0e62370 Cr-Commit-Position: refs/heads/master@{#36749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -7 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 3 chunks +37 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-06 00:10:47 UTC) #1
john.yan
lgtm with one comment: I think Float32 would be a better name than Single.
4 years, 6 months ago (2016-06-06 13:08:15 UTC) #2
JaideepBajwa
On 2016/06/06 13:08:15, john.yan wrote: > lgtm with one comment: I think Float32 would be ...
4 years, 6 months ago (2016-06-06 13:28:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043553002/1
4 years, 6 months ago (2016-06-06 13:28:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 13:56:29 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 13:59:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d048ed80c64a7775287d04836da554d7d0e62370
Cr-Commit-Position: refs/heads/master@{#36749}

Powered by Google App Engine
This is Rietveld 408576698