Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1962773002: PPC: Added macro functions for stfd[u],stfs[u],lfd[u],lfs[u] (Closed)

Created:
4 years, 7 months ago by JaideepBajwa
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Added macro functions for stfd[u],stfs[u],lfd[u],lfs[u] Added macro functions to handle large offsets(>16bits) in StoreDoubleU/ LoadDoubleU/StoreSingle/StoreSingleU/LoadSingle/LoadSingleU. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/b35aefd3387bb58e04208e6405a3f97b1ef3e39e Cr-Commit-Position: refs/heads/master@{#36118}

Patch Set 1 #

Patch Set 2 : reverted use of macro where not necessary #

Patch Set 3 : fixed white space formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -5 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +19 lines, -2 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 2 chunks +77 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
JaideepBajwa
PTAL
4 years, 7 months ago (2016-05-09 17:49:16 UTC) #1
MTBrandyberry
The changes to macro-assembler are good. However, I don't see where we are actually taking ...
4 years, 7 months ago (2016-05-09 18:16:52 UTC) #2
john.yan
On 2016/05/09 17:49:16, bjaideep wrote: > PTAL StoreDoubleU is kind of confusing, might be using ...
4 years, 7 months ago (2016-05-09 18:44:36 UTC) #3
MTBrandyberry
LGTM
4 years, 7 months ago (2016-05-09 18:53:28 UTC) #4
JaideepBajwa
On 2016/05/09 18:44:36, john.yan wrote: > On 2016/05/09 17:49:16, bjaideep wrote: > > PTAL > ...
4 years, 7 months ago (2016-05-09 18:56:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962773002/40001
4 years, 7 months ago (2016-05-09 19:13:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/15871)
4 years, 7 months ago (2016-05-09 19:15:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962773002/40001
4 years, 7 months ago (2016-05-09 19:49:50 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-09 19:59:16 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 20:01:24 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b35aefd3387bb58e04208e6405a3f97b1ef3e39e
Cr-Commit-Position: refs/heads/master@{#36118}

Powered by Google App Engine
This is Rietveld 408576698