third_party/WebKit/Source/bindings/templates/methods.cpp - Issue 2043503002: Add [CEReactions] IDL attributes for Custom Elements V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/methods.cpp

Issue 2043503002: Add [CEReactions] IDL attributes for Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/attributes.cpp ('K') | « third_party/WebKit/Source/bindings/templates/attributes.cpp ('k') | third_party/WebKit/Source/core/dom/Attr.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/methods.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/methods.cpp b/third_party/WebKit/Source/bindings/templates/methods.cpp

index 034343e174b10ade3609fecaec62d18fb43b24e5..aa406e47a73e620d50d093b7eee724ff81c5468c 100644

--- a/third_party/WebKit/Source/bindings/templates/methods.cpp

+++ b/third_party/WebKit/Source/bindings/templates/methods.cpp

@@ -21,6 +21,9 @@ static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const

{% if not method.is_static %}

{{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());

{% endif %}

+ {% if method.is_ce_reactions %}

+ CEReactionsScope reactions;

Yuki 2016/06/06 06:13:56 Ditto.

kojii 2016/06/07 07:51:17 Done too.

+ {% endif %}

{% if method.is_custom_element_callbacks %}

V0CustomElementProcessingStack::CallbackDeliveryScope deliveryScope;

{% endif %}