third_party/WebKit/Source/bindings/templates/attributes.cpp - Issue 2043503002: Add [CEReactions] IDL attributes for Custom Elements V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/attributes.cpp

Issue 2043503002: Add [CEReactions] IDL attributes for Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_methods.py ('k') | third_party/WebKit/Source/bindings/templates/methods.cpp » ('j') | third_party/WebKit/Source/bindings/templates/methods.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/attributes.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/attributes.cpp b/third_party/WebKit/Source/bindings/templates/attributes.cpp

index a63ee63eff341fda31ad43dbecd046cb4db4af98..2c22687d6d5279f574ec0024d3f59ad9f19ccb9f 100644

--- a/third_party/WebKit/Source/bindings/templates/attributes.cpp

+++ b/third_party/WebKit/Source/bindings/templates/attributes.cpp

@@ -331,6 +331,9 @@ v8::Local<v8::Value> v8Value, const v8::FunctionCallbackInfo<v8::Value>& info

}

{% endif %}

{# Pre-set context #}

+ {% if attribute.is_ce_reactions %}

+ CEReactionsScope reactions;

Yuki 2016/06/06 06:13:56 nit: I'd prefer cereactionsScope or ceReactionsSco

kojii 2016/06/07 07:51:17 Done.

+ {% endif %}

{% if attribute.is_custom_element_callbacks or

(attribute.is_reflect and

not(attribute.idl_type == 'DOMString' and is_node)) %}