Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 204323004: Reland "Add out-of-line constant pool support to Arm." (Closed)

Created:
6 years, 9 months ago by rmcilroy
Modified:
6 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+564 lines, -115 lines) Patch
M src/a64/assembler-a64.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/a64/assembler-a64.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.h View 6 chunks +49 lines, -4 lines 0 comments Download
M src/arm/assembler-arm.cc View 16 chunks +301 lines, -71 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 7 chunks +47 lines, -8 lines 0 comments Download
M src/arm/builtins-arm.cc View 1 chunk +17 lines, -11 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 6 chunks +31 lines, -10 lines 0 comments Download
M src/assembler.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/heap.cc View 8 chunks +50 lines, -8 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
Fixes a build error due to unused variable in release mode. Only change is addition ...
6 years, 9 months ago (2014-03-19 10:08:48 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-19 10:12:59 UTC) #2
rmcilroy
6 years, 9 months ago (2014-03-19 10:32:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20053 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698