src/arm/full-codegen-arm.cc - Issue 204323004: Reland "Add out-of-line constant pool support to Arm."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/full-codegen-arm.cc

Issue 204323004: Reland "Add out-of-line constant pool support to Arm." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/full-codegen-arm.cc

diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc

index ef5aee61dc3cd8c92948054ec55ecec50f9551c5..691039507fa101337a32c26f947531a7159239dc 100644

--- a/src/arm/full-codegen-arm.cc

+++ b/src/arm/full-codegen-arm.cc

@@ -4835,8 +4835,7 @@ static Address GetInterruptImmediateLoadAddress(Address pc) {

load_address -= Assembler::kInstrSize;

ASSERT(Assembler::IsMovW(Memory::int32_at(load_address)));

} else {

- // TODO(rmcilroy): uncomment when IsLdrPpImmediateOffset lands.

- // ASSERT(IsLdrPpImmediateOffset(Memory::int32_at(load_address)));

+ ASSERT(Assembler::IsLdrPpImmediateOffset(Memory::int32_at(load_address)));

}

return load_address;

}

« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »