Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 204323003: DevTools: Merge highlightPosition and revealLine methods on SourceFrame. (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Merge highlightPosition and revealLine methods on SourceFrame. This patch keeps highlightPosition method on SourceFrame for backwards compatibility with corresponding virtual methods on View. R=lushnikov@chromium.org, lushnikov, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169551

Patch Set 1 #

Patch Set 2 : Fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -57 lines) Patch
M LayoutTests/inspector/editor/editor-test.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/editor/text-editor-reveal-line.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/reveal-execution-line.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/CodeMirrorTextEditor.js View 4 chunks +9 lines, -6 lines 0 comments Download
M Source/devtools/front_end/SourceFrame.js View 4 chunks +21 lines, -42 lines 0 comments Download
M Source/devtools/front_end/SourcesPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/TextEditor.js View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vsevik
PTAL
6 years, 9 months ago (2014-03-19 08:53:13 UTC) #1
lushnikov
lgtm
6 years, 9 months ago (2014-03-19 10:10:46 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-19 11:40:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/204323003/1
6 years, 9 months ago (2014-03-19 11:40:59 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 12:10:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-19 12:10:37 UTC) #6
vsevik
6 years, 9 months ago (2014-03-19 14:49:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r169551 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698