Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1537)

Unified Diff: Source/devtools/front_end/TextEditor.js

Issue 204323003: DevTools: Merge highlightPosition and revealLine methods on SourceFrame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed tests Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/SourcesPanel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TextEditor.js
diff --git a/Source/devtools/front_end/TextEditor.js b/Source/devtools/front_end/TextEditor.js
index 7771e8a1a5b610731b44c0774ba9fd8d82823d4f..c06f5fe9eb7f412a663c6a971b06806fe30d8460 100644
--- a/Source/devtools/front_end/TextEditor.js
+++ b/Source/devtools/front_end/TextEditor.js
@@ -114,11 +114,6 @@ WebInspector.TextEditor.prototype = {
/**
* @param {number} lineNumber
- */
- revealLine: function(lineNumber) { },
-
- /**
- * @param {number} lineNumber
* @param {boolean} disabled
* @param {boolean} conditional
*/
@@ -157,8 +152,9 @@ WebInspector.TextEditor.prototype = {
/**
* @param {number} lineNumber
* @param {number=} columnNumber
+ * @param {boolean=} shouldHighlight
*/
- highlightPosition: function(lineNumber, columnNumber) { },
+ revealPosition: function(lineNumber, columnNumber, shouldHighlight) { },
clearPositionHighlight: function() { },
« no previous file with comments | « Source/devtools/front_end/SourcesPanel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698