Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2043213002: Roll virtualenv 12.0->15.0.2 (Closed)

Created:
4 years, 6 months ago by nodir
Modified:
4 years, 6 months ago
Reviewers:
Vadim Sh., iannucci
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Roll virtualenv 12.0->15.0.2 There was a bug in pip: pip.wheel.Wheel.supported() returned True for wheels that supports only linux_x86_64 while python was 32bit. pip 8.1.0 fixed that bug: https://github.com/pypa/pip/releases/tag/8.1.0 virtualenv 15.0.2 embeds pip 8.1.2 pip 8.1.2 also removed --download-cache option because pip now manages its own cache The reason why we vendor virtualenv is described in bootstrap/virtualenv/README.chromium context: failure https://chromium-swarm.appspot.com/user/task/2f45ae7d718b3e10 R=vadimsh@chromium.org, iannucci@chromium.org BUG=620145 Committed: https://chromium.googlesource.com/infra/infra/+/2e5f0bf5c7849bc532c6977627f9f69ba254072d

Patch Set 1 #

Total comments: 6

Patch Set 2 : readme #

Patch Set 3 : vendor virtualenv #

Patch Set 4 : rebased #

Patch Set 5 : test only: dep on https://github.com/nodir/virtualenv/tree/tcltk #

Patch Set 6 : vendor virtualenv and exclude from gender check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3879 lines, -452 lines) Patch
M DEPS View 1 2 3 5 1 chunk +0 lines, -5 lines 0 comments Download
M PRESUBMIT.py View 1 2 3 4 5 3 chunks +12 lines, -5 lines 0 comments Download
M bootstrap/.gitignore View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M bootstrap/README.md View 1 1 chunk +1 line, -1 line 0 comments Download
M bootstrap/bootstrap.py View 1 chunk +1 line, -2 lines 0 comments Download
A bootstrap/virtualenv/.gitattributes View 1 2 5 1 chunk +1 line, -0 lines 0 comments Download
A bootstrap/virtualenv/.gitignore View 1 2 5 1 chunk +11 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/.travis.yml View 1 2 5 1 chunk +43 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/AUTHORS.txt View 1 2 5 1 chunk +91 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/CONTRIBUTING.rst View 1 2 5 1 chunk +21 lines, -0 lines 0 comments Download
A + bootstrap/virtualenv/LICENSE.txt View 1 2 5 1 chunk +3 lines, -1 line 0 comments Download
A bootstrap/virtualenv/MANIFEST.in View 1 2 5 1 chunk +12 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/README.chromium View 1 2 5 1 chunk +9 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/README.rst View 1 2 5 1 chunk +31 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/appveyor.yml View 1 2 5 1 chunk +25 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/bin/rebuild-script.py View 1 2 5 1 chunk +80 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/Makefile View 1 2 5 1 chunk +130 lines, -0 lines 0 comments Download
A + bootstrap/virtualenv/docs/changes.rst View 1 2 5 4 chunks +158 lines, -66 lines 0 comments Download
A bootstrap/virtualenv/docs/conf.py View 1 2 5 1 chunk +153 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/development.rst View 1 2 5 1 chunk +61 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/index.rst View 1 2 5 1 chunk +137 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/installation.rst View 1 2 5 1 chunk +58 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/make.bat View 1 2 5 1 chunk +170 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/reference.rst View 1 2 5 1 chunk +261 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/userguide.rst View 1 2 5 1 chunk +258 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/scripts/virtualenv View 1 2 5 1 chunk +3 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/setup.cfg View 1 2 5 1 chunk +2 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/setup.py View 1 2 5 1 chunk +123 lines, -0 lines 0 comments Download
A + bootstrap/virtualenv/tests/__init__.py View 1 2 5 0 chunks +-1 lines, --1 lines 0 comments Download
A bootstrap/virtualenv/tests/test_activate.sh View 1 2 5 1 chunk +96 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/tests/test_activate_output.expected View 1 2 5 1 chunk +2 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/tests/test_cmdline.py View 1 2 5 1 chunk +44 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/tests/test_virtualenv.py View 1 2 5 1 chunk +139 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/tox.ini View 1 2 5 1 chunk +36 lines, -0 lines 0 comments Download
A + bootstrap/virtualenv/virtualenv.py View 1 2 5 36 chunks +343 lines, -373 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/activate.bat View 1 2 5 1 chunk +30 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/activate.csh View 1 2 5 1 chunk +36 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/activate.fish View 1 2 5 1 chunk +76 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/activate.ps1 View 1 2 5 1 chunk +150 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/activate.sh View 1 2 5 1 chunk +78 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/activate_this.py View 1 2 5 1 chunk +34 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/deactivate.bat View 1 2 5 1 chunk +19 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/distutils.cfg View 1 2 5 1 chunk +6 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/distutils-init.py View 1 2 5 1 chunk +101 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/python-config View 1 2 5 1 chunk +78 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/site.py View 1 2 5 1 chunk +758 lines, -0 lines 0 comments Download
A + bootstrap/virtualenv/virtualenv_support/__init__.py View 1 2 5 0 chunks +-1 lines, --1 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_support/argparse-1.4.0-py2.py3-none-any.whl View 1 2 5 Binary file 0 comments Download
A bootstrap/virtualenv/virtualenv_support/pip-8.1.2-py2.py3-none-any.whl View 1 2 5 Binary file 0 comments Download
A + bootstrap/virtualenv/virtualenv_support/setuptools-21.2.1-py2.py3-none-any.whl View 1 2 5 Binary file 0 comments Download
A bootstrap/virtualenv/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl View 1 2 5 Binary file 0 comments Download

Messages

Total messages: 17 (8 generated)
nodir
PTAL Tested by - sshing to the host where the build failed - `fetch infra` ...
4 years, 6 months ago (2016-06-08 00:18:55 UTC) #2
Vadim Sh.
lgtm https://codereview.chromium.org/2043213002/diff/1/bootstrap/bootstrap.py File bootstrap/bootstrap.py (left): https://codereview.chromium.org/2043213002/diff/1/bootstrap/bootstrap.py#oldcode154 bootstrap/bootstrap.py:154: [pip, 'install', '--no-index', '--download-cache', update README.md not to ...
4 years, 6 months ago (2016-06-08 00:26:30 UTC) #4
nodir
https://codereview.chromium.org/2043213002/diff/1/bootstrap/bootstrap.py File bootstrap/bootstrap.py (left): https://codereview.chromium.org/2043213002/diff/1/bootstrap/bootstrap.py#oldcode154 bootstrap/bootstrap.py:154: [pip, 'install', '--no-index', '--download-cache', On 2016/06/08 00:26:30, Vadim Sh. ...
4 years, 6 months ago (2016-06-08 00:46:05 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043213002/20001
4 years, 6 months ago (2016-06-08 00:46:22 UTC) #7
Vadim Sh.
https://codereview.chromium.org/2043213002/diff/1/bootstrap/bootstrap.py File bootstrap/bootstrap.py (right): https://codereview.chromium.org/2043213002/diff/1/bootstrap/bootstrap.py#newcode222 bootstrap/bootstrap.py:222: virtualenv.make_environment_relocatable(env) On 2016/06/08 00:46:05, nodir wrote: > On 2016/06/08 ...
4 years, 6 months ago (2016-06-08 00:48:38 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-08 00:55:56 UTC) #10
nodir
Bots cannot apply a patchset with vendored virtualenv, so I ran tests on depsed https://github.com/nodir/virtualenv/tree/tcltk ...
4 years, 6 months ago (2016-06-17 02:18:53 UTC) #11
Vadim Sh.
lgtm
4 years, 6 months ago (2016-06-17 02:23:19 UTC) #12
nodir1
4 years, 6 months ago (2016-06-17 02:36:29 UTC) #16
Message was sent while issue was closed.
Committed patchset #6 (id:120001) manually as
2e5f0bf5c7849bc532c6977627f9f69ba254072d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698