Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: PRESUBMIT.py

Issue 2043213002: Roll virtualenv 12.0->15.0.2 (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: vendor virtualenv and exclude from gender check Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | bootstrap/.gitignore » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 1451cc5911e3d230555d6d2fd97e8b9c299d2466..85ceea05d0f281039e1e4432e5649575323f6d9c 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -32,6 +32,13 @@ DISABLED_PROJECTS = [
'bootstrap/virtualenv',
]
+# List of third_party direcories.
+THIRD_PARTY_DIRS = [
+ 'appengine/third_party',
+ # Remove this when virtualenv is unvendored.
+ 'bootstrap/virtualenv',
+]
+
# List of directories to jshint.
JSHINT_PROJECTS = [
'appengine/chromium_cq_status',
@@ -41,9 +48,7 @@ JSHINT_PROJECTS = [
'appengine/chrome_infra_packages',
]
# List of blacklisted directories that we don't want to jshint.
-JSHINT_PROJECTS_BLACKLIST = [
- 'appengine/third_party',
-]
+JSHINT_PROJECTS_BLACKLIST = THIRD_PARTY_DIRS
# Files that must not be modified (regex)
# Paths tested are relative to the directory containing this file.
@@ -340,11 +345,13 @@ def JshintChecks(input_api, output_api): # pragma: no cover
def CommonChecks(input_api, output_api): # pragma: no cover
+ third_party_filter = lambda path: input_api.FilterSourceFile(
+ path, black_list=THIRD_PARTY_DIRS)
output = input_api.RunTests(PylintChecks(input_api, output_api))
output.extend(input_api.RunTests(JshintChecks(input_api, output_api)))
output.extend(BrokenLinksChecks(input_api, output_api))
- output.extend(
- input_api.canned_checks.CheckGenderNeutral(input_api, output_api))
+ output.extend( input_api.canned_checks.CheckGenderNeutral(
+ input_api, output_api, source_file_filter=third_party_filter))
return output
« no previous file with comments | « DEPS ('k') | bootstrap/.gitignore » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698