src/runtime/runtime-literals.cc - Issue 2043183003: Replace all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-literals.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: simplifying checks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-literals.cc

diff --git a/src/runtime/runtime-literals.cc b/src/runtime/runtime-literals.cc

index 4b94f2ab7c8cec9bd322e81b6eb65707eabcec80..e1923d2a66465f06df1677cf6d5a649ff55fb5e1 100644

--- a/src/runtime/runtime-literals.cc

+++ b/src/runtime/runtime-literals.cc

@@ -85,7 +85,9 @@ MUST_USE_RESULT static MaybeHandle<Object> CreateObjectLiteralBoilerplate(

uint32_t element_index = 0;

if (key->ToArrayIndex(&element_index)) {

// Array index (uint32).

- if (value->IsUninitialized()) value = handle(Smi::FromInt(0), isolate);

+ if (value->IsUninitialized(isolate)) {

+ value = handle(Smi::FromInt(0), isolate);

+ }

maybe_result = JSObject::SetOwnElementIgnoreAttributes(

boilerplate, element_index, value, NONE);

} else {