src/runtime/runtime-forin.cc - Issue 2043183003: Replace all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-forin.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: simplifying checks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-forin.cc

diff --git a/src/runtime/runtime-forin.cc b/src/runtime/runtime-forin.cc

index 68c1092bd6cae138245a27ec73c8395f5b52715f..48896d49d8e3f1717b70736e60bbdc64bc48e3d1 100644

--- a/src/runtime/runtime-forin.cc

+++ b/src/runtime/runtime-forin.cc

@@ -64,7 +64,7 @@ MaybeHandle<Object> HasEnumerableProperty(Isolate* isolate,

Handle<Object> prototype;

ASSIGN_RETURN_ON_EXCEPTION(isolate, prototype,

JSProxy::GetPrototype(proxy), Object);

- if (prototype->IsNull()) break;

+ if (prototype->IsNull(isolate)) break;

// We already have a stack-check in JSProxy::GetPrototype.

return HasEnumerableProperty(

isolate, Handle<JSReceiver>::cast(prototype), key);