src/crankshaft/hydrogen.cc - Issue 2043183003: Replace all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: simplifying checks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/hydrogen.cc

diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc

index 9e934f0a13fcfe11eff106da036461d70efe6175..889c223323263873749a27a142ed36ff5960c518 100644

--- a/src/crankshaft/hydrogen.cc

+++ b/src/crankshaft/hydrogen.cc

@@ -12206,9 +12206,9 @@ void HOptimizedGraphBuilder::BuildEmitInObjectProperties(

double_box, HObjectAccess::ForHeapNumberValue(), double_value);

value_instruction = double_box;

} else if (representation.IsSmi()) {

- value_instruction = value->IsUninitialized()

- ? graph()->GetConstant0()

- : Add<HConstant>(value);

+ value_instruction = value->IsUninitialized(isolate())

+ ? graph()->GetConstant0()

+ : Add<HConstant>(value);

// Ensure that value is stored as smi.

access = access.WithRepresentation(representation);

} else {