src/crankshaft/hydrogen-instructions.cc - Issue 2043183003: Replace all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen-instructions.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: simplifying checks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/hydrogen-instructions.cc

diff --git a/src/crankshaft/hydrogen-instructions.cc b/src/crankshaft/hydrogen-instructions.cc

index fb810ff16f12cdc2af37b50b54209a9aa8de67b6..fd5c5c54bfc66c8368483f628f5926e7f1c246ae 100644

--- a/src/crankshaft/hydrogen-instructions.cc

+++ b/src/crankshaft/hydrogen-instructions.cc

@@ -2414,7 +2414,7 @@ Maybe<HConstant*> HConstant::CopyToTruncatedNumber(Isolate* isolate,

new(zone) HConstant(1) : new(zone) HConstant(0);

} else if (handle->IsUndefined(isolate)) {

res = new (zone) HConstant(std::numeric_limits<double>::quiet_NaN());

- } else if (handle->IsNull()) {

+ } else if (handle->IsNull(isolate)) {

res = new(zone) HConstant(0);

} else if (handle->IsString()) {

res = new(zone) HConstant(String::ToNumber(Handle<String>::cast(handle)));