Replace all remaining Oddball checks with new function

Replace all remaining Oddball checks with new function

This CL removes the IsUndefined() and Co. methods from Object and HeapObject.
The new method all take the isolate as parameter.

BUG=

Committed: https://crrev.com/ccefb3ae5fe967288d568013fb04e8761eafebc5
Cr-Commit-Position: refs/heads/master@{#36921}

[Camillo Bruni, 2016-06-08 11:43:48]

cbruni@chromium.org changed reviewers:
+ mstarzinger@chromium.org, verwaest@chromium.org

[Camillo Bruni, 2016-06-08 11:43:49]

PTAL again... this will be the last one.

[Michael Starzinger, 2016-06-08 15:58:22]

LGTM.

https://codereview.chromium.org/2043183003/diff/20001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/2043183003/diff/20001/src/objects-inl.h#newco...
src/objects-inl.h:158: // TODO(cbruni): remove once all the isolate-based
versions are in place.
nit: This TODO should actually be addressed by this CL, right? Can we remove it?

https://codereview.chromium.org/2043183003/diff/20001/src/objects-inl.h#newco...
src/objects-inl.h:2192:
value->IsUninitialized(HeapObject::cast(value)->GetIsolate())) {
nit: Just use "this->GetIsolate()" here, avoiding the SMI check.

https://codereview.chromium.org/2043183003/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2043183003/diff/20001/src/objects.h#newcode1030
src/objects.h:1030: // TODO(cbruni): clean up once isolate-based versions are in
place.
nit: This TODO should actually be addressed by this CL, right?

https://codereview.chromium.org/2043183003/diff/20001/src/objects.h#newcode1553
src/objects.h:1553: // TODO(cbruni): clean up once isolate-based versions are in
place.
nit: This TODO should actually be addressed by this CL, right?

[Toon Verwaest, 2016-06-09 14:13:26]

lgtm

[Camillo Bruni, 2016-06-09 16:36:46]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-06-09 16:36:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2043183003/#ps40001
(title: "addressing nits")

[commit-bot: I haz the power, 2016-06-09 16:36:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043183003/40001

[commit-bot: I haz the power, 2016-06-09 16:38:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 16:38:25]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/7044)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/2944)

[Camillo Bruni, 2016-06-09 16:43:01]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 16:43:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043183003/60001

[commit-bot: I haz the power, 2016-06-09 16:44:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 16:44:35]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/7019)

[Camillo Bruni, 2016-06-09 16:55:16]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 16:55:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043183003/80001

[commit-bot: I haz the power, 2016-06-09 16:59:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 16:59:15]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/7052)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[Camillo Bruni, 2016-06-10 08:39:25]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-06-10 08:39:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2043183003/#ps100001
(title: "fixing cctest and unittest")

[commit-bot: I haz the power, 2016-06-10 08:39:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043183003/100001

[commit-bot: I haz the power, 2016-06-10 08:45:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 08:46:01]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16932)

[Camillo Bruni, 2016-06-10 09:28:56]

cbruni@chromium.org changed reviewers:
+ yangguo@chromium.org

[Camillo Bruni, 2016-06-10 09:28:57]

yangguo@ PTAL regexp/.*

https://codereview.chromium.org/2043183003/diff/20001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/2043183003/diff/20001/src/objects-inl.h#newco...
src/objects-inl.h:2192:
value->IsUninitialized(HeapObject::cast(value)->GetIsolate())) {
On 2016/06/08 at 15:58:20, Michael Starzinger wrote:
> nit: Just use "this->GetIsolate()" here, avoiding the SMI check.

tunnelvision.

https://codereview.chromium.org/2043183003/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2043183003/diff/20001/src/objects.h#newcode1030
src/objects.h:1030: // TODO(cbruni): clean up once isolate-based versions are in
place.
On 2016/06/08 at 15:58:20, Michael Starzinger wrote:
> nit: This TODO should actually be addressed by this CL, right?

nah, let's just keep the todos alive a bit longer ;P

[Yang, 2016-06-10 09:38:13]

On 2016/06/10 09:28:57, Camillo Bruni wrote:
> yangguo@ PTAL regexp/.*
> 
> https://codereview.chromium.org/2043183003/diff/20001/src/objects-inl.h
> File src/objects-inl.h (right):
> 
>
https://codereview.chromium.org/2043183003/diff/20001/src/objects-inl.h#newco...
> src/objects-inl.h:2192:
> value->IsUninitialized(HeapObject::cast(value)->GetIsolate())) {
> On 2016/06/08 at 15:58:20, Michael Starzinger wrote:
> > nit: Just use "this->GetIsolate()" here, avoiding the SMI check.
> 
> tunnelvision.
> 
> https://codereview.chromium.org/2043183003/diff/20001/src/objects.h
> File src/objects.h (right):
> 
>
https://codereview.chromium.org/2043183003/diff/20001/src/objects.h#newcode1030
> src/objects.h:1030: // TODO(cbruni): clean up once isolate-based versions are
in
> place.
> On 2016/06/08 at 15:58:20, Michael Starzinger wrote:
> > nit: This TODO should actually be addressed by this CL, right?
> 
> nah, let's just keep the todos alive a bit longer ;P

src/regexp lgtm

[Camillo Bruni, 2016-06-10 09:38:38]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-06-10 09:38:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2043183003/#ps120001
(title: "fixing another test")

[commit-bot: I haz the power, 2016-06-10 09:38:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043183003/120001

[commit-bot: I haz the power, 2016-06-10 09:56:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 09:56:38]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)

[Camillo Bruni, 2016-06-13 09:34:45]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-06-13 09:34:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, verwaest@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2043183003/#ps160001
(title: "fixing wrong early return")

[commit-bot: I haz the power, 2016-06-13 09:34:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043183003/160001

[commit-bot: I haz the power, 2016-06-13 09:37:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 09:37:28]

Try jobs failed on following builders:
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/7190)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[Camillo Bruni, 2016-06-13 09:40:56]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-06-13 09:40:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, verwaest@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2043183003/#ps180001
(title: "keep em coming")

[commit-bot: I haz the power, 2016-06-13 09:41:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2043183003/180001

[Camillo Bruni, 2016-06-13 09:53:08]

cbruni@chromium.org changed reviewers:
+ ahaas@chromium.org

[Camillo Bruni, 2016-06-13 09:53:09]

ahaas@ PTAL again wasm/.* ...

[ahaas, 2016-06-13 09:57:00]

On 2016/06/13 at 09:53:09, cbruni wrote:
> ahaas@ PTAL again wasm/.* ...

wasm lgtm

[commit-bot: I haz the power, 2016-06-13 10:19:04]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-06-13 10:21:08]

Description was changed from

==========
Replace all remaining Oddball checks with new function

This CL removes the IsUndefined() and Co. methods from Object and HeapObject.
The new method all take the isolate as parameter.

BUG=
==========

to

==========
Replace all remaining Oddball checks with new function

This CL removes the IsUndefined() and Co. methods from Object and HeapObject.
The new method all take the isolate as parameter.

BUG=

Committed: https://crrev.com/ccefb3ae5fe967288d568013fb04e8761eafebc5
Cr-Commit-Position: refs/heads/master@{#36921}
==========

[commit-bot: I haz the power, 2016-06-13 10:21:10]

Patchset 10 (id:??) landed as
https://crrev.com/ccefb3ae5fe967288d568013fb04e8761eafebc5
Cr-Commit-Position: refs/heads/master@{#36921}

[Camillo Bruni, 2016-06-13 11:39:46]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/2060213002/ by cbruni@chromium.org.

The reason for reverting is: failing tests.