src/code-stubs.cc - Issue 2043183003: Replace all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/code-stubs.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: keep em coming Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/code-stubs.cc

diff --git a/src/code-stubs.cc b/src/code-stubs.cc

index 7094da33b843781201af433c25a81da3b057c250..8ec4fed005db342991899ec6fc59ad12e1b53f13 100644

--- a/src/code-stubs.cc

+++ b/src/code-stubs.cc

@@ -4502,8 +4502,8 @@ bool ToBooleanICStub::Types::UpdateStatus(Isolate* isolate,

return false;

} else if (object->IsBoolean()) {

Add(BOOLEAN);

- return object->IsTrue();

- } else if (object->IsNull()) {

+ return object->IsTrue(isolate);

+ } else if (object->IsNull(isolate)) {

Add(NULL_TYPE);

return false;

} else if (object->IsSmi()) {

« no previous file with comments | « src/builtins.cc ('k') | src/compiler/access-info.cc » ('j') | no next file with comments »