Move CSSValue->CSSStyleValue logic out of StylePropertyMap and into the StyleValueFactory.

Move CSSValue->CSSStyleValue logic out of StylePropertyMap and into the StyleValueFactory.

Also rename StylePropertyMap::StyleValueVector to just
CSSStyleValueVector.

This is in preparation for adding logic to build more types of
CSSStyleValues and TransformComponents out of CSSValues. It doesn't
make sense for the StylePropertyMap to contain all the logic around
different properties.

BUG=545318
Committed: https://crrev.com/5a2a7ffb7245ca5d7491aafd2388ff94aeb95d47
Cr-Commit-Position: refs/heads/master@{#398503}

[meade_UTC10, 2016-06-07 05:38:06]

Description was changed from

==========
Move CSSValue->CSSStyleValue logic out of StylePropertyMap and into the
StyleValueFactory.

This is in preparation for adding logic to build more types of
CSSStyleValues and TransformComponents out of CSSValues. It doesn't
make sense for the StylePropertyMap to contain all the logic around
different properties.

BUG=545318
==========

to

==========
Move CSSValue->CSSStyleValue logic out of StylePropertyMap and into the
StyleValueFactory.

Also rename StylePropertyMap::StyleValueVector to just
CSSStyleValueVector.

This is in preparation for adding logic to build more types of
CSSStyleValues and TransformComponents out of CSSValues. It doesn't
make sense for the StylePropertyMap to contain all the logic around
different properties.

BUG=545318
==========

[meade_UTC10, 2016-06-07 05:38:24]

meade@chromium.org changed reviewers:
+ timloh@chromium.org

[meade_UTC10, 2016-06-07 08:33:25]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 08:33:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042943003/1

[commit-bot: I haz the power, 2016-06-07 09:25:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 09:25:48]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2016-06-08 04:19:17]

lgtm

https://codereview.chromium.org/2042943003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp (right):

https://codereview.chromium.org/2042943003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp:38: if
(styleValueVector.size() != 1)
should put a TODO to handle this case

[meade_UTC10, 2016-06-08 07:10:25]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2016-06-08 07:10:26]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2042943003/#ps20001
(title: "Add TODO for CSSValueSequences")

[commit-bot: I haz the power, 2016-06-08 07:10:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042943003/20001

[commit-bot: I haz the power, 2016-06-08 07:12:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 07:12:38]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[meade_UTC10, 2016-06-08 07:13:16]

https://codereview.chromium.org/2042943003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp (right):

https://codereview.chromium.org/2042943003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp:38: if
(styleValueVector.size() != 1)
On 2016/06/08 04:19:17, Timothy Loh wrote:
> should put a TODO to handle this case

Done.

[meade_UTC10, 2016-06-08 07:23:46]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2016-06-08 07:23:47]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2042943003/#ps40001
(title: "sync to HEAD")

[commit-bot: I haz the power, 2016-06-08 07:24:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042943003/40001

[commit-bot: I haz the power, 2016-06-08 08:40:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-08 08:42:10]

Description was changed from

==========
Move CSSValue->CSSStyleValue logic out of StylePropertyMap and into the
StyleValueFactory.

Also rename StylePropertyMap::StyleValueVector to just
CSSStyleValueVector.

This is in preparation for adding logic to build more types of
CSSStyleValues and TransformComponents out of CSSValues. It doesn't
make sense for the StylePropertyMap to contain all the logic around
different properties.

BUG=545318
==========

to

==========
Move CSSValue->CSSStyleValue logic out of StylePropertyMap and into the
StyleValueFactory.

Also rename StylePropertyMap::StyleValueVector to just
CSSStyleValueVector.

This is in preparation for adding logic to build more types of
CSSStyleValues and TransformComponents out of CSSValues. It doesn't
make sense for the StylePropertyMap to contain all the logic around
different properties.

BUG=545318

Committed: https://crrev.com/5a2a7ffb7245ca5d7491aafd2388ff94aeb95d47
Cr-Commit-Position: refs/heads/master@{#398503}
==========

[commit-bot: I haz the power, 2016-06-08 08:42:12]

Patchset 3 (id:??) landed as
https://crrev.com/5a2a7ffb7245ca5d7491aafd2388ff94aeb95d47
Cr-Commit-Position: refs/heads/master@{#398503}