third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h - Issue 2042943003: Move CSSValue->CSSStyleValue logic out of StylePropertyMap and into the StyleValueFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h

Issue 2042943003: Move CSSValue->CSSStyleValue logic out of StylePropertyMap and into the StyleValueFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stylevaue

Patch Set: sync to HEAD Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp ('k') | third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h

diff --git a/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h b/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h

index 8886d586c1bd1efa968b15013abb061caf9ee27a..d4c274e45444b9b6ffcbbd2b189ef9594b27029a 100644

--- a/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h

+++ b/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h

@@ -21,17 +21,16 @@ class CORE_EXPORT StylePropertyMap : public GarbageCollectedFinalized<StylePrope

WTF_MAKE_NONCOPYABLE(StylePropertyMap);

DEFINE_WRAPPERTYPEINFO();

public:

- typedef HeapVector<Member<CSSStyleValue>> StyleValueVector;

typedef std::pair<String, CSSStyleValueOrCSSStyleValueSequence> StylePropertyMapEntry;

virtual ~StylePropertyMap() { }

// Accessors.

CSSStyleValue* get(const String& propertyName, ExceptionState&);

- StyleValueVector getAll(const String& propertyName, ExceptionState&);

+ CSSStyleValueVector getAll(const String& propertyName, ExceptionState&);

bool has(const String& propertyName, ExceptionState&);

- virtual StyleValueVector getAll(CSSPropertyID) = 0;

+ virtual CSSStyleValueVector getAll(CSSPropertyID) = 0;

virtual Vector<String> getProperties() = 0;

// Modifiers.

@@ -50,7 +49,6 @@ protected:

virtual HeapVector<StylePropertyMapEntry> getIterationEntries() = 0;

IterationSource* startIteration(ScriptState*, ExceptionState&) override;

- StyleValueVector cssValueToStyleValueVector(CSSPropertyID, const CSSValue&);

};

} // namespace blink