build/config/mac/rules.gni - Issue 2042723003: Set the right product type in GN for mac bundle targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/mac/rules.gni

Issue 2042723003: Set the right product type in GN for mac bundle targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/mac/rules.gni

diff --git a/build/config/mac/rules.gni b/build/config/mac/rules.gni

index 9be71bcb5e81da2db80e436c59594880a00b9a90..bc7d104c9bb8808cf204b168ee8833b83679f1b6 100644

--- a/build/config/mac/rules.gni

+++ b/build/config/mac/rules.gni

@@ -296,7 +296,7 @@ template("mac_app_bundle") {

":$_executable_bundle_data",

":$_info_plist_bundle_data",

]

+ product_type = "com.apple.product-type.application"

sdefresne 2016/06/06 14:26:40 nit: can you restore the blank line you removed?

bundle_root_dir = "$root_out_dir/${_output_name}.app/Contents"

bundle_resources_dir = "$bundle_root_dir/Resources"

bundle_executable_dir = "$bundle_root_dir/MacOS"

« no previous file with comments | « no previous file | no next file » | no next file with comments »