Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: build/config/mac/rules.gni

Issue 2042723003: Set the right product type in GN for mac bundle targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/mac/base_rules.gni") 5 import("//build/config/mac/base_rules.gni")
6 6
7 # Generates Info.plist files for Mac apps and frameworks. 7 # Generates Info.plist files for Mac apps and frameworks.
8 # 8 #
9 # Arguments 9 # Arguments
10 # 10 #
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 "public_deps", 289 "public_deps",
290 "testonly", 290 "testonly",
291 ]) 291 ])
292 if (!defined(deps)) { 292 if (!defined(deps)) {
293 deps = [] 293 deps = []
294 } 294 }
295 deps += [ 295 deps += [
296 ":$_executable_bundle_data", 296 ":$_executable_bundle_data",
297 ":$_info_plist_bundle_data", 297 ":$_info_plist_bundle_data",
298 ] 298 ]
299 299 product_type = "com.apple.product-type.application"
sdefresne 2016/06/06 14:26:40 nit: can you restore the blank line you removed?
300 bundle_root_dir = "$root_out_dir/${_output_name}.app/Contents" 300 bundle_root_dir = "$root_out_dir/${_output_name}.app/Contents"
301 bundle_resources_dir = "$bundle_root_dir/Resources" 301 bundle_resources_dir = "$bundle_root_dir/Resources"
302 bundle_executable_dir = "$bundle_root_dir/MacOS" 302 bundle_executable_dir = "$bundle_root_dir/MacOS"
303 } 303 }
304 } 304 }
305 305
306 # Template to package a loadable_module into a .plugin bundle. 306 # Template to package a loadable_module into a .plugin bundle.
307 # 307 #
308 # This takes no extra arguments that differ from a loadable_module. 308 # This takes no extra arguments that differ from a loadable_module.
309 template("mac_plugin_bundle") { 309 template("mac_plugin_bundle") {
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 ]) 358 ])
359 if (!defined(deps)) { 359 if (!defined(deps)) {
360 deps = [] 360 deps = []
361 } 361 }
362 deps += [ ":$_loadable_module_bundle_data" ] 362 deps += [ ":$_loadable_module_bundle_data" ]
363 363
364 bundle_root_dir = "$root_out_dir/$_output_name.plugin/Contents" 364 bundle_root_dir = "$root_out_dir/$_output_name.plugin/Contents"
365 bundle_executable_dir = "$bundle_root_dir/MacOS" 365 bundle_executable_dir = "$bundle_root_dir/MacOS"
366 } 366 }
367 } 367 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698