Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2042723003: Set the right product type in GN for mac bundle targets. (Closed)

Created:
4 years, 6 months ago by msarda
Modified:
4 years, 6 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the right product type in GN for mac bundle targets. BUG=NONE Committed: https://crrev.com/5d9216f03c0e5a41af0bde3cbcf4b8ce794e89b6 Cr-Commit-Position: refs/heads/master@{#399873}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/mac/rules.gni View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 11 (3 generated)
msarda
Please take a look.
4 years, 6 months ago (2016-06-06 13:46:18 UTC) #2
sdefresne
https://codereview.chromium.org/2042723003/diff/20001/build/config/mac/rules.gni File build/config/mac/rules.gni (right): https://codereview.chromium.org/2042723003/diff/20001/build/config/mac/rules.gni#newcode299 build/config/mac/rules.gni:299: product_type = "com.apple.product-type.application" nit: can you restore the blank ...
4 years, 6 months ago (2016-06-06 14:26:40 UTC) #3
sdefresne
nit: description, please change "mac bundle targets" to "mac app bundle targets"
4 years, 6 months ago (2016-06-06 14:27:02 UTC) #4
sdefresne
lgtm
4 years, 6 months ago (2016-06-15 06:34:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042723003/20001
4 years, 6 months ago (2016-06-15 08:25:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 10:19:04 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 10:19:09 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 10:22:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d9216f03c0e5a41af0bde3cbcf4b8ce794e89b6
Cr-Commit-Position: refs/heads/master@{#399873}

Powered by Google App Engine
This is Rietveld 408576698