Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2042693003: Revert of [build] Use sysroot for linux compilation with clang (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [build] Use sysroot for linux compilation with clang (patchset #5 id:80001 of https://codereview.chromium.org/2028623002/ ) Reason for revert: sysroot logic breaks "make arm" Original issue's description: > [build] Use sysroot for linux compilation with clang > > This ports the configuration for using a sysroot from > chromium's common.gypi. > > This is restricted to clang only. > > BUG=chromium:474921, chromium:616032 > LOG=y > > Committed: https://crrev.com/c47d3c63695d2999752f5fc61ff171f3ff100553 > Cr-Commit-Position: refs/heads/master@{#36729} TBR=jochen@chromium.org,vogelheim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921, chromium:616032 Committed: https://crrev.com/0e2d92967db1d7502b5b5bed5813dca901ebdf97 Cr-Commit-Position: refs/heads/master@{#36741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -56 lines) Patch
M DEPS View 1 chunk +0 lines, -12 lines 0 comments Download
M gypfiles/standalone.gypi View 3 chunks +0 lines, -44 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [build] Use sysroot for linux compilation with clang
4 years, 6 months ago (2016-06-06 11:00:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042693003/1
4 years, 6 months ago (2016-06-06 11:00:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 11:02:14 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 11:04:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e2d92967db1d7502b5b5bed5813dca901ebdf97
Cr-Commit-Position: refs/heads/master@{#36741}

Powered by Google App Engine
This is Rietveld 408576698