Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: chrome/browser/extensions/extension_protocols_unittest.cc

Issue 2042483002: Fix web_accesible_resources enforcement for Site Isolation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes for code review, removed filter exceptions. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_protocols_unittest.cc
diff --git a/chrome/browser/extensions/extension_protocols_unittest.cc b/chrome/browser/extensions/extension_protocols_unittest.cc
index 96cd5f4867749c423348f61e009944ee0381d7b6..89d7371f6afdce3560db5da65d64608a2a49b949 100644
--- a/chrome/browser/extensions/extension_protocols_unittest.cc
+++ b/chrome/browser/extensions/extension_protocols_unittest.cc
@@ -211,7 +211,7 @@ TEST_F(ExtensionProtocolTest, IncognitoRequest) {
// First test a main frame request.
{
// It doesn't matter that the resource doesn't exist. If the resource
- // is blocked, we should see ADDRESS_UNREACHABLE. Otherwise, the request
+ // is blocked, we should see BLOCKED_BY_CLIENT. Otherwise, the request
// should just fail because the file doesn't exist.
std::unique_ptr<net::URLRequest> request(
resource_context_.GetRequestContext()->CreateRequest(
@@ -224,8 +224,8 @@ TEST_F(ExtensionProtocolTest, IncognitoRequest) {
EXPECT_EQ(net::ERR_FILE_NOT_FOUND, request->status().error()) <<
cases[i].name;
} else {
- EXPECT_EQ(net::ERR_ADDRESS_UNREACHABLE, request->status().error()) <<
- cases[i].name;
+ EXPECT_EQ(net::ERR_BLOCKED_BY_CLIENT, request->status().error())
+ << cases[i].name;
}
}
@@ -242,8 +242,8 @@ TEST_F(ExtensionProtocolTest, IncognitoRequest) {
EXPECT_EQ(net::ERR_FILE_NOT_FOUND, request->status().error()) <<
cases[i].name;
} else {
- EXPECT_EQ(net::ERR_ADDRESS_UNREACHABLE, request->status().error()) <<
- cases[i].name;
+ EXPECT_EQ(net::ERR_BLOCKED_BY_CLIENT, request->status().error())
+ << cases[i].name;
}
}
}

Powered by Google App Engine
This is Rietveld 408576698