Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: extensions/browser/extension_protocols.cc

Issue 2042483002: Fix web_accesible_resources enforcement for Site Isolation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes for code review, removed filter exceptions. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/extension_navigation_throttle.cc ('k') | extensions/extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_protocols.cc
diff --git a/extensions/browser/extension_protocols.cc b/extensions/browser/extension_protocols.cc
index c97f172607acbc2650537d6895a60a5704da4208..0ae21efbf1cf15bc60b61bc88cce195206b79209 100644
--- a/extensions/browser/extension_protocols.cc
+++ b/extensions/browser/extension_protocols.cc
@@ -422,8 +422,8 @@ ExtensionProtocolHandler::MaybeCreateJob(
// TODO(mpcomplete): better error code.
Devlin 2016/06/06 22:17:22 Is this considered a better error code? :)
nasko 2016/06/06 23:23:03 I don't know : ), hence why I left the comment. I
if (!AllowExtensionResourceLoad(
request, is_incognito_, extension, extension_info_map_)) {
- return new net::URLRequestErrorJob(
- request, network_delegate, net::ERR_ADDRESS_UNREACHABLE);
+ return new net::URLRequestErrorJob(request, network_delegate,
+ net::ERR_BLOCKED_BY_CLIENT);
}
// If this is a disabled extension only allow the icon to load.
« no previous file with comments | « extensions/browser/extension_navigation_throttle.cc ('k') | extensions/extensions.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698