third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2042353002: Remove floats from LayoutView in removeFloatingOrPositionedChildFromBlockLists

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2042353002: Remove floats from LayoutView in removeFloatingOrPositionedChildFromBlockLists (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-writing-modes-in-layoutview-with-floats-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 1cbedcad8db3996a92f175d35cad6c5aeda90a76..545287f6605b2b6888d78bf3f38b6d1f9cc5ca3b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -161,7 +161,7 @@ void LayoutBox::removeFloatingOrPositionedChildFromBlockLists()

if (isFloating()) {

LayoutBlockFlow* parentBlockFlow = nullptr;

- for (LayoutObject* curr = parent(); curr && !curr->isLayoutView(); curr = curr->parent()) {

+ for (LayoutObject* curr = parent(); curr; curr = curr->parent()) {

if (curr->isLayoutBlockFlow()) {

LayoutBlockFlow* currBlockFlow = toLayoutBlockFlow(curr);

if (!parentBlockFlow || currBlockFlow->containsFloat(this))