chrome/browser/engagement/site_engagement_helper.h - Issue 2042243004: Construct the site engagement helper with a site engagement service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_helper.h

Issue 2042243004: Construct the site engagement helper with a site engagement service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewer comments, rebase to fix leak Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/engagement/site_engagement_helper.h

diff --git a/chrome/browser/engagement/site_engagement_helper.h b/chrome/browser/engagement/site_engagement_helper.h

index f55ab586b550d7575776d6cbeff02627cb8f50d9..df1b0549a8456a7a6224f1a7a572cc204a0b4ce3 100644

--- a/chrome/browser/engagement/site_engagement_helper.h

+++ b/chrome/browser/engagement/site_engagement_helper.h

@@ -165,6 +165,7 @@ class SiteEngagementService::Helper

InputTracker input_tracker_;

MediaTracker media_tracker_;

+ SiteEngagementService* service_;

bool record_engagement_;

DISALLOW_COPY_AND_ASSIGN(Helper);

« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_helper.cc » ('j') | chrome/browser/engagement/site_engagement_service.cc » ('J')