chrome/browser/engagement/site_engagement_helper.h - Issue 2042243004: Construct the site engagement helper with a site engagement service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/engagement/site_engagement_helper.h

Issue 2042243004: Construct the site engagement helper with a site engagement service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewer comments, rebase to fix leak Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_helper.cc » ('j') | chrome/browser/engagement/site_engagement_service.cc » ('J')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_ENGAGEMENT_SITE_ENGAGEMENT_HELPER_H_	5 #ifndef CHROME_BROWSER_ENGAGEMENT_SITE_ENGAGEMENT_HELPER_H_

6 #define CHROME_BROWSER_ENGAGEMENT_SITE_ENGAGEMENT_HELPER_H_	6 #define CHROME_BROWSER_ENGAGEMENT_SITE_ENGAGEMENT_HELPER_H_

7	7

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "base/timer/timer.h"	9 #include "base/timer/timer.h"

10 #include "chrome/browser/engagement/site_engagement_metrics.h"	10 #include "chrome/browser/engagement/site_engagement_metrics.h"

(...skipping 147 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
158 // current WebContents URL.	158 // current WebContents URL.

159 void RecordMediaPlaying(bool is_hidden);	159 void RecordMediaPlaying(bool is_hidden);

160	160

161 // content::WebContentsObserver overrides.	161 // content::WebContentsObserver overrides.

162 void DidFinishNavigation(content::NavigationHandle* handle) override;	162 void DidFinishNavigation(content::NavigationHandle* handle) override;

163 void WasShown() override;	163 void WasShown() override;

164 void WasHidden() override;	164 void WasHidden() override;

165	165

166 InputTracker input_tracker_;	166 InputTracker input_tracker_;

167 MediaTracker media_tracker_;	167 MediaTracker media_tracker_;

	168 SiteEngagementService* service_;

168 bool record_engagement_;	169 bool record_engagement_;

169	170

170 DISALLOW_COPY_AND_ASSIGN(Helper);	171 DISALLOW_COPY_AND_ASSIGN(Helper);

171 };	172 };

172	173

173 #endif // CHROME_BROWSER_ENGAGEMENT_SITE_ENGAGEMENT_HELPER_H_	174 #endif // CHROME_BROWSER_ENGAGEMENT_SITE_ENGAGEMENT_HELPER_H_

OLD	NEW