Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2042243002: build: add recipe tests to infra/infra_repo_trybot (Closed)

Created:
4 years, 6 months ago by Paweł Hajdan Jr.
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -0 lines) Patch
M scripts/slave/recipes/infra/infra_repo_trybot.py View 1 chunk +7 lines, -0 lines 0 comments Download
M scripts/slave/recipes/infra/infra_repo_trybot.expected/basic.json View 1 chunk +19 lines, -0 lines 0 comments Download
M scripts/slave/recipes/infra/infra_repo_trybot.expected/basic_gerrit.json View 1 chunk +19 lines, -0 lines 0 comments Download
M scripts/slave/recipes/infra/infra_repo_trybot.expected/infra_internal.json View 1 chunk +19 lines, -0 lines 0 comments Download
M scripts/slave/recipes/infra/infra_repo_trybot.expected/infra_internal_gerrit.json View 1 chunk +19 lines, -0 lines 0 comments Download
M scripts/slave/recipes/infra/infra_repo_trybot.expected/only_DEPS.json View 1 chunk +19 lines, -0 lines 0 comments Download
M scripts/slave/recipes/infra/infra_repo_trybot.expected/only_glyco_python.json View 1 chunk +19 lines, -0 lines 0 comments Download
M scripts/slave/recipes/infra/infra_repo_trybot.expected/only_go.json View 1 chunk +19 lines, -0 lines 0 comments Download
M scripts/slave/recipes/infra/infra_repo_trybot.expected/only_js.json View 1 chunk +19 lines, -0 lines 0 comments Download
M scripts/slave/recipes/infra/infra_repo_trybot.expected/only_python.json View 1 chunk +19 lines, -0 lines 0 comments Download
M scripts/slave/recipes/infra/infra_repo_trybot.expected/rietveld_tests.json View 1 chunk +19 lines, -0 lines 0 comments Download
M scripts/slave/recipes/infra/infra_repo_trybot.expected/rietveld_tests_on_win.json View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Paweł Hajdan Jr.
4 years, 6 months ago (2016-06-07 11:16:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042243002/1
4 years, 6 months ago (2016-06-07 11:16:39 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-07 11:20:50 UTC) #6
Michael Achenbach
lgtm
4 years, 6 months ago (2016-06-07 11:54:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042243002/1
4 years, 6 months ago (2016-06-07 11:56:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/978385980717ba748aa3492de68429a18e5d1530
4 years, 6 months ago (2016-06-07 12:00:01 UTC) #12
Sergiy Byelozyorov
lgtm
4 years, 6 months ago (2016-06-07 12:01:57 UTC) #13
tandrii(chromium)
Please add reference in description to CL which moves the recipes to infra/infra, and vise ...
4 years, 6 months ago (2016-06-07 12:04:58 UTC) #14
Paweł Hajdan Jr.
On 2016/06/07 at 12:04:58, tandrii wrote: > Please add reference in description to CL which ...
4 years, 6 months ago (2016-06-07 12:23:32 UTC) #15
tandrii(chromium)
4 years, 6 months ago (2016-06-07 12:40:35 UTC) #16
Message was sent while issue was closed.
On 2016/06/07 12:23:32, Paweł Hajdan Jr. wrote:
> On 2016/06/07 at 12:04:58, tandrii wrote:
> > Please add reference in description to CL which moves the recipes to
> infra/infra, and vise versa, so that in case someone later on needs to revert
> the CLs, it's easier to figure out the dependencies. And no, just BUG= isn't
> sufficient, though necessary.
> 
> Okay - please note I don't always notice replies to closed CLs.
Noted.

> FWIW, the infra recipes CL is https://codereview.chromium.org/2041313002 .
Again, this should go to the description.

Powered by Google App Engine
This is Rietveld 408576698