infra: check in recipes running on master.chromium.infra

infra: check in recipes running on master.chromium.infra

This is copied from build@ae3e05b8231926a47dc92e72a3933936f9d795ac. No changes except rewriting DEPS and line wrapping.

See https://groups.google.com/a/chromium.org/d/msg/infra-dev/tW99wuWVSWQ/dMAnzk-sBQAJ
for context.

Also see https://codereview.chromium.org/2042243002 .

BUG=617565
Committed: https://chromium.googlesource.com/infra/infra/+/1204bc0c3439b4195865174411825aaa7dff68c8

[Paweł Hajdan Jr., 2016-06-07 10:17:02]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 10:17:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041313002/1

[commit-bot: I haz the power, 2016-06-07 10:21:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 10:21:04]

Dry run: Try jobs failed on following builders:
  Infra Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Infra%20Presubmit/build...)

[Paweł Hajdan Jr., 2016-06-07 10:23:47]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 10:23:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041313002/20001

[commit-bot: I haz the power, 2016-06-07 10:30:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 10:30:03]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-06-07 11:01:13]

phajdan.jr@chromium.org changed reviewers:
+ sergiyb@chromium.org, tandrii@chromium.org

[Sergiy Byelozyorov, 2016-06-07 12:00:00]

Can you please upload two patchsets: one with original recipe code and another
making changes needed. Or were there no changes?

https://codereview.chromium.org/2041313002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2041313002/diff/20001/PRESUBMIT.py#newcode270
PRESUBMIT.py:270: black_list += [r'^recipes/recipes\.py$']
Why is this needed? Can we fix recipes.py instead? Doesn't have to be part of
this CL, but please add a TODO.

[tandrii(chromium), 2016-06-07 12:02:37]

High level comments:

1) description referencing HUGE discussion with no conclusion is lame. My take:
Summarize discussion and write it as description - save (unware) reviewers and
later readers time.

2) copy-pasta of stuff from different repo demands a hash of a commit of the
revision in the source repo from which files are copied.

3) If this intends to be a move from build to infra/infra, then this CL should
reference a CL deleting the builds in infra and vise versa, even if they don't
land at the same time.

[tandrii(chromium), 2016-06-07 12:03:14]

On 2016/06/07 12:02:37, tandrii(chromium) wrote:
> High level comments:
> 
> 1) description referencing HUGE discussion with no conclusion is lame. My
take:
> Summarize discussion and write it as description - save (unware) reviewers and
> later readers time.
s/no conclusion/no obvious conclusion
particularly as the thread is not "closed", there might be more replies later
on.

[Paweł Hajdan Jr., 2016-06-07 12:07:19]

This is copied from build@ae3e05b8231926a47dc92e72a3933936f9d795ac (see
recipes.cfg).

No changes except rewriting DEPS and line wrapping.

https://codereview.chromium.org/2041313002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2041313002/diff/20001/PRESUBMIT.py#newcode270
PRESUBMIT.py:270: black_list += [r'^recipes/recipes\.py$']
On 2016/06/07 at 12:00:00, Sergiy Byelozyorov wrote:
> Why is this needed? Can we fix recipes.py instead? Doesn't have to be part of
this CL, but please add a TODO.

Other repos also have it. It generates pylint warnings (style).

IMO if you'd like to fix, feel free to e.g. file a bug - I really think it's
beyond scope for this CL, and I'd hesitate to add a TODO without asking other
recipe engine owners.

[Paweł Hajdan Jr., 2016-06-07 12:08:32]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 12:08:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041313002/40001

[commit-bot: I haz the power, 2016-06-07 12:14:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 12:14:54]

Dry run: Try jobs failed on following builders:
  Infra Linux Precise 32 Tester on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Infra%20Linux%20Precise...)

[Paweł Hajdan Jr., 2016-06-07 12:23:05]

Description was changed from

==========
infra: check in recipes running on master.chromium.infra

See
https://groups.google.com/a/chromium.org/d/msg/infra-dev/tW99wuWVSWQ/dMAnzk-s...
for context.

BUG=617565
==========

to

==========
infra: check in recipes running on master.chromium.infra

See
https://groups.google.com/a/chromium.org/d/msg/infra-dev/tW99wuWVSWQ/dMAnzk-s...
for context.

Also see https://codereview.chromium.org/2042243002 .

BUG=617565
==========

[tandrii(chromium), 2016-06-07 12:38:09]

On 2016/06/07 12:07:19, Paweł Hajdan Jr. wrote:
> This is copied from build@ae3e05b8231926a47dc92e72a3933936f9d795ac (see
> recipes.cfg).
> 
> No changes except rewriting DEPS and line wrapping.
This should go to description.

> 
> https://codereview.chromium.org/2041313002/diff/20001/PRESUBMIT.py
> File PRESUBMIT.py (right):
> 
> https://codereview.chromium.org/2041313002/diff/20001/PRESUBMIT.py#newcode270
> PRESUBMIT.py:270: black_list += [r'^recipes/recipes\.py$']
> On 2016/06/07 at 12:00:00, Sergiy Byelozyorov wrote:
> > Why is this needed? Can we fix recipes.py instead? Doesn't have to be part
of
> this CL, but please add a TODO.
> 
> Other repos also have it. It generates pylint warnings (style).
> 
> IMO if you'd like to fix, feel free to e.g. file a bug - I really think it's
> beyond scope for this CL, and I'd hesitate to add a TODO without asking other
> recipe engine owners.
You are the OWNER of the recipes-py. What's the point of cloning bad recipes.py
code?
Yes, it's out of scope of this CL, but this CL should be blocked by that
cleanup, because *this repo* is supposed to be pylint-checked.
Why add another exception?

[Paweł Hajdan Jr., 2016-06-07 13:00:36]

Description was changed from

==========
infra: check in recipes running on master.chromium.infra

See
https://groups.google.com/a/chromium.org/d/msg/infra-dev/tW99wuWVSWQ/dMAnzk-s...
for context.

Also see https://codereview.chromium.org/2042243002 .

BUG=617565
==========

to

==========
infra: check in recipes running on master.chromium.infra

This is copied from build@ae3e05b8231926a47dc92e72a3933936f9d795ac. No changes
except rewriting DEPS and line wrapping.

See
https://groups.google.com/a/chromium.org/d/msg/infra-dev/tW99wuWVSWQ/dMAnzk-s...
for context.

Also see https://codereview.chromium.org/2042243002 .

BUG=617565
==========

[Paweł Hajdan Jr., 2016-06-07 13:06:16]

PTAL

[Paweł Hajdan Jr., 2016-06-07 13:06:21]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 13:06:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041313002/60001

[commit-bot: I haz the power, 2016-06-07 13:12:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 13:12:44]

Dry run: This issue passed the CQ dry run.

[Sergiy Byelozyorov, 2016-06-07 13:19:46]

lgtm

https://codereview.chromium.org/2041313002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2041313002/diff/20001/PRESUBMIT.py#newcode270
PRESUBMIT.py:270: black_list += [r'^recipes/recipes\.py$']
On 2016/06/07 12:07:18, Paweł Hajdan Jr. wrote:
> On 2016/06/07 at 12:00:00, Sergiy Byelozyorov wrote:
> > Why is this needed? Can we fix recipes.py instead? Doesn't have to be part
of
> this CL, but please add a TODO.
> 
> Other repos also have it. It generates pylint warnings (style).
> 
> IMO if you'd like to fix, feel free to e.g. file a bug - I really think it's
> beyond scope for this CL, and I'd hesitate to add a TODO without asking other
> recipe engine owners.

We've discussed it offline and Pawel added comment and bug. Thanks for that.

[Paweł Hajdan Jr., 2016-06-07 13:25:59]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2016-06-07 13:26:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041313002/60001

[commit-bot: I haz the power, 2016-06-07 13:27:44]

Description was changed from

==========
infra: check in recipes running on master.chromium.infra

This is copied from build@ae3e05b8231926a47dc92e72a3933936f9d795ac. No changes
except rewriting DEPS and line wrapping.

See
https://groups.google.com/a/chromium.org/d/msg/infra-dev/tW99wuWVSWQ/dMAnzk-s...
for context.

Also see https://codereview.chromium.org/2042243002 .

BUG=617565
==========

to

==========
infra: check in recipes running on master.chromium.infra

This is copied from build@ae3e05b8231926a47dc92e72a3933936f9d795ac. No changes
except rewriting DEPS and line wrapping.

See
https://groups.google.com/a/chromium.org/d/msg/infra-dev/tW99wuWVSWQ/dMAnzk-s...
for context.

Also see https://codereview.chromium.org/2042243002 .

BUG=617565

Committed:
https://chromium.googlesource.com/infra/infra/+/1204bc0c3439b4195865174411825...
==========

[commit-bot: I haz the power, 2016-06-07 13:27:46]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/1204bc0c3439b4195865174411825...

[estaab, 2016-06-07 17:55:10]

estaab@chromium.org changed reviewers:
+ estaab@chromium.org

[estaab, 2016-06-07 17:55:11]

lgtm