Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: base/native_library_unittest.cc

Issue 2042103002: Clean up some nits in base::NativeLibrary. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/file_path.h" 5 #include "base/files/file_path.h"
6 #include "base/native_library.h" 6 #include "base/native_library.h"
7 #include "base/strings/utf_string_conversions.h"
7 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
8 9
9 namespace base { 10 namespace base {
10 11
11 const FilePath::CharType kDummyLibraryPath[] = 12 const FilePath::CharType kDummyLibraryPath[] =
12 FILE_PATH_LITERAL("dummy_library"); 13 FILE_PATH_LITERAL("dummy_library");
13 14
14 TEST(NativeLibraryTest, LoadFailure) { 15 TEST(NativeLibraryTest, LoadFailure) {
15 NativeLibraryLoadError error; 16 NativeLibraryLoadError error;
16 NativeLibrary library = 17 EXPECT_FALSE(LoadNativeLibrary(FilePath(kDummyLibraryPath), &error));
17 LoadNativeLibrary(FilePath(kDummyLibraryPath), &error);
18 EXPECT_TRUE(library == nullptr);
19 EXPECT_FALSE(error.ToString().empty()); 18 EXPECT_FALSE(error.ToString().empty());
20 } 19 }
21 20
22 // |error| is optional and can be null. 21 // |error| is optional and can be null.
23 TEST(NativeLibraryTest, LoadFailureWithNullError) { 22 TEST(NativeLibraryTest, LoadFailureWithNullError) {
24 NativeLibrary library = 23 EXPECT_FALSE(LoadNativeLibrary(FilePath(kDummyLibraryPath), nullptr));
25 LoadNativeLibrary(FilePath(kDummyLibraryPath), nullptr); 24 }
26 EXPECT_TRUE(library == nullptr); 25
26 TEST(NativeLibraryTest, GetNativeLibraryName) {
27 const char kExpectedName[] =
28 #if defined(OS_IOS)
29 "mylib";
30 #elif defined(OS_MACOSX)
31 "mylib.dylib";
32 #elif defined(OS_POSIX)
33 "libmylib.so";
34 #elif defined(OS_WIN)
35 "mylib.dll";
36 #endif
37 EXPECT_EQ(ASCIIToUTF16(kExpectedName),
38 GetNativeLibraryName(ASCIIToUTF16("mylib")));
27 } 39 }
28 40
29 } // namespace base 41 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698